Project

General

Profile

action #54770

[functional][y] Rename test variable WORKAROUND_MODULES as is used in staging as normal behavior

Added by okurz almost 2 years ago. Updated almost 2 years ago.

Status:
Resolved
Priority:
Low
Assignee:
Category:
Enhancement to existing tests
Target version:
Start date:
2019-07-29
Due date:
2019-09-24
% Done:

0%

Estimated time:
3.00 h
Difficulty:

Description

Motivation

Many test suites on osd define WORKAROUND_MODULES mentioning bsc#1054375 which is VERIFIED FIXED by now – since two years already ;) . So I guess we need to either remove the WORKAROUND_MODULES part or update the test suite comments

As we can see name is confusing. It was introduced as temporary thing, but is used in SLE 15 staging

Acceptance criteria

History

#1 Updated by riafarov almost 2 years ago

This is used in all staging tests, the main problem is that we thought it's temporary, so used wrong naming =). I will highjack this ticket to rename the variable.

#2 Updated by riafarov almost 2 years ago

  • Subject changed from [functional][y] Evaluate if test variable WORKAROUND_MODULES is still necessary, bsc#1054375 is VERIFIED FIXED to [functional][y] Rename test variable WORKAROUND_MODULES as is used in staging as normal behavior
  • Description updated (diff)
  • Due date set to 2019-09-10
  • Target version set to future

#3 Updated by okurz almost 2 years ago

thank you. I don't even consider this hijacking. I recommend to keep the original AC still in place though with "suite settings do not mention the above bug anymore but a more recent one" but you can extend that to " … or no bug" of course :)

#4 Updated by riafarov almost 2 years ago

  • Status changed from New to Workable
  • Estimated time set to 3.00 h

#5 Updated by ybonatakis almost 2 years ago

  • Status changed from Workable to In Progress
  • Assignee set to ybonatakis

#6 Updated by ybonatakis almost 2 years ago

I run two test(x86_64) against sle12 and sle15 without the WORKAROUND_MODULES and both work properly. As the AC1 requires to rename it, I want to ask if i can go on and remove it completely.

#7 Updated by ybonatakis almost 2 years ago

  • Status changed from In Progress to Feedback

#8 Updated by riafarov almost 2 years ago

  • Description updated (diff)

#9 Updated by riafarov almost 2 years ago

  • Due date changed from 2019-09-10 to 2019-09-24

Yanis has pointed out that we can get rid of the variable, but need to set proper settings in the test suite.

#10 Updated by riafarov almost 2 years ago

  • Status changed from Feedback to Resolved

I guess we can resolve this one, hooray ;).

#11 Updated by ybonatakis almost 2 years ago

The PR is still in WIP and with various changes due to the experiments in order to make it work for xen.

Also available in: Atom PDF