action #54350
closedGenerate docs for all PRs without publishing them
0%
Description
Currently the generate-documentation script checks a few conditions:
- Branch is master
- A PR is being built
- We want to publish the docs
If all of these are true docs are generated and published. Conversely we won't know about problems with docs until after changes have been merged, if these checks do work as specified.
#2188 optimizes the decision to (not) run the script.
We can take it one step further by enabling a job to generate, or generate and publish, in the cases we care for and have the script do one or both. And while we're at it, let's remove the second-guessing from the docs script, and have the logic in one place.
Updated by okurz about 5 years ago
- Status changed from New to Blocked
- Assignee set to andriinikitin
- Target version set to Current Sprint
@andriinikitin I assume this is blocked by your work in #57548 , right?
Updated by okurz about 5 years ago
- Blocked by action #57548: Move building and publishing of docs to CircleCI added
Updated by andriinikitin about 5 years ago
- Blocked by deleted (action #57548: Move building and publishing of docs to CircleCI)
Updated by andriinikitin about 5 years ago
- Related to action #57548: Move building and publishing of docs to CircleCI added
Updated by andriinikitin about 5 years ago
- Status changed from Blocked to In Progress
The request "Generate docs for all PRs" was fixed by https://github.com/os-autoinst/openQA/pull/2405 , and documentation is being built in every CI run.
I don't see how " let's remove the second-guessing from the docs script " can be beneficial, so I am not implementing it at the moment.
So I mark this ticket as Resolved, and feel free to reassign it and reopen or create another ticket if you think more work must be done.
Updated by andriinikitin about 5 years ago
- Status changed from In Progress to Resolved