Project

General

Profile

Actions

action #54101

closed

Developer mode "pause test" does not actually pause it

Added by AdamWill almost 5 years ago. Updated almost 5 years ago.

Status:
Rejected
Priority:
Low
Assignee:
Category:
Feature requests
Target version:
-
Start date:
2019-07-10
Due date:
% Done:

0%

Estimated time:

Description

Since the rewrite of interactive mode to developer mode, there's a "Pause on screen mismatch" box with options that let you interrupt the test and enter the needle editor when a match fails, instead of the test failing.

However...I might be wrong about this, but AFAICS, despite the use of the word "pause", this no longer actually pauses the VM. In the 'interactive mode' implementation it did - the VM was paused until you hit the button to resume it. But I was just editing needles in developer mode and noticed a case where the VM was in one state when I entered the needle editor, but by the time I exited the needle editor, the execution of the test had continued, the screen was different, and the newly-created needle no longer matched. (This is a case where we click a button to "do something", then assert that a progress indicator for the "something" is displayed: by the time I'd finished creating the new progress indicator needle, the "something" operation had completed and the progress indicator was no longer on the screen).

If I'm right about this, either the VM should actually be paused in this case, or at least the text should be changed not to claim that it will be paused...

Actions #1

Updated by okurz almost 5 years ago

  • Category set to Feature requests
  • Priority changed from Normal to Low

Unless I am mistaken that was a design choice by coolo and mkittler to make the behaviour consistent with other backends where it is not possible to "pause" the actual machine. To be exact the description never mentions it would "pause the actual machine", just pauses test execution, whatever that means in detail. So if you like to give it a try, add a better explanation in the existing strings.

Actions #2

Updated by mkittler almost 5 years ago

Yes, it is designed to pause the test execution. Like @okurz says, pausing the SUT itself is not possible for all backends. Besides, one use-case we have in mind is to access the SUT (e.g. via VNC) and do things while the test is paused.

The help popover already says test execution and explicitly says that the SUT is not paused. I don't think we can be more clear.

I believe it is a bad idea in general to assert a screen which goes away on its own after a certain amount of time. You just can't be sure that isotovideo will be fast enough to do the assertion.

Actions #3

Updated by okurz almost 5 years ago

  • Status changed from New to Rejected
  • Assignee set to okurz

I second that. I guess with this we can close this ticket again. @AdamWill feel free to reopen if we misunderstood you.

Actions

Also available in: Atom PDF