Project

General

Profile

Actions
Copy link

action #45740

closed

Please run "tools/tidy" script time to time

Added by henrich_debian about 6 years ago. Updated almost 6 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
okurz
Category:
Support
Target version:
-
Start date:
2019-01-06
Due date:
% Done:

0%

Estimated time:

Description

I've tried to build Debian package with master/HEAD but got an error as below.

make  check-local
make[4]: Entering directory '/build/os-autoinst-4.5.1527308405.8b586d5.20190104'
./tools/tidy --check 
--- ./t/16-send_with_fd.t       2019-01-04 11:55:46.000000000 +0000   
+++ ./t/16-send_with_fd.t.tdy   2019-01-06 13:43:40.463129038 +0000   
@@ -33,7 +33,7 @@    
shutdown($ask, 2);      
my @cmsg = $msg->cmsghdr();       
-    my $fd   = unpack('i', $cmsg[2]); 
+    my $fd = unpack('i', $cmsg[2]);   
POSIX::write($fd, $msg->buf(), 4) 
|| die "Failed to write echo to pipe: $!";   
RUN tools/tidy script before checkin
make[4]: *** [Makefile:1457: check-local] Error 1

It's a blocker to be build package, should be done as check-in basis.

Actions
Copy link
 #1

Updated by mkittler about 6 years ago

  • Status changed from New to Feedback

That the files are tidied is a perquisite for a change to get merged on master. It looks like you're Perl tidy is too old and hence you're now getting a diff compared to the new version we recently switched to.

So which version of Perl tidy are you using? We're currently using the version from 20181120.

Likely it makes sense to exclude the tidy check when building the package as it is absolutely not critical.

Actions
Copy link
 #2

Updated by coolo about 6 years ago

  • Status changed from Feedback to Rejected

I get your diff with the old version, but you need this:

20180220 -> 20181120

Of course you don't need it - if you disable the check

Actions
Copy link
 #3

Updated by okurz about 6 years ago

  • Category set to Support

Hm, we could maybe crosscheck the tidy script on call because we know from cpanfile which version we want to use

Actions
Copy link
 #4

Updated by okurz about 6 years ago

  • Status changed from Rejected to Feedback
  • Assignee set to okurz
Actions
Copy link
 #5

Updated by henrich_debian about 6 years ago

Okay, I got it. I have not known about an incompatibility between newest perltidy and previous one.
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=916653

I'll disable it until 20181120 would be introduced into Debian.
Sorry for the noise.

Actions
Copy link
 #6

Updated by okurz about 6 years ago

Nevertheless thanks for the report because this problem was not only seen by you but also hit others. This is why I introduced the additional version checks within the tidy call itself. https://github.com/os-autoinst/openQA/pull/1942 is already merged, only waiting for https://github.com/os-autoinst/os-autoinst/pull/1082 for os-autoinst.

Actions
Copy link
 #7

Updated by okurz almost 6 years ago

  • Status changed from Feedback to Resolved

PR merged and effective. I guess we are good

Actions
Copy link

Also available in: Atom PDF