action #41486

Port openQA to Mojolicious 8.0

Added by mkittler over 1 year ago. Updated over 1 year ago.

Status:ResolvedStart date:24/09/2018
Priority:NormalDue date:
Assignee:mkittler% Done:

0%

Category:Organisational
Target version:Done
Difficulty:
Duration:

Description

Almost all of our tests still pass after updating to Mojolicious 8.0 - so likely only a few adjustments are required. In particular, the tests 24-worker.t and 25-serverstartup.t fail.


Related issues

Duplicated by openQA Project - action #41801: 25-serverstartup.t test fails with recent Mojolicious Rejected 29/09/2018

History

#1 Updated by coolo over 1 year ago

  • Category set to Organisational
  • Target version set to Ready

This needs staging testing afterwards

#2 Updated by coolo over 1 year ago

  • Duplicated by action #41801: 25-serverstartup.t test fails with recent Mojolicious added

#3 Updated by mkittler over 1 year ago

It seems that setting the log level via environment variable MOJO_LOG_LEVEL doesn't work anymore.

Eg. this would let the tests pass: https://github.com/os-autoinst/openQA/compare/master...Martchus:port_to_mojo_8?expand=1

#4 Updated by mkittler over 1 year ago

  • Status changed from New to In Progress
  • Assignee set to mkittler

#5 Updated by coolo over 1 year ago

  • Status changed from In Progress to Resolved
  • Target version changed from Ready to Done

Let's stick to 7.94 in production until Sebastian finds out

#6 Updated by kraih over 1 year ago

Easier testing was actually one of the motivations for the change in Mojolicious. I don't think there's a need to use the MOJO_LOG_LEVEL environment variable at all anymore in openQA. Calls to $app->log->level('...') now always have a higher precedence.

Also available in: Atom PDF