Project

General

Profile

Actions

action #35206

closed

Needle selection disfunctional on screenshots without tags

Added by nicksinger about 6 years ago. Updated over 5 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
Regressions/Crashes
Target version:
Start date:
2018-04-19
Due date:
% Done:

0%

Estimated time:

Description

In the new version of OpenQA (4.5.1524056562.74e334c1), it can happen that the needle selection is clickable but nothing appears - e.g.: https://openqa.suse.de/tests/1628297#step/kdump_and_crash/20
I suspect that this happens on every screenshot which has no tags.

This is pretty confusing and not the most pretty thing. IMHO the candidate selection should be disabled if there is no content.

Actions #1

Updated by coolo about 6 years ago

  • Category set to Regressions/Crashes
  • Target version set to Ready

Before there was '-None-' the only choice in a combobox - https://openqa.opensuse.org/tests/658456#step/logs_from_installation_system/20

Actions #2

Updated by nicksinger about 6 years ago

This was a little more obvious - even though not perfect ;)
As I already wrote, I'd suggest to just disable the button (and maybe change its text a little) if no content is available. Then it is grayed out and more obvious that there is no content to expect when you click on it.
Right now, it feels a little bit as if openQA is still loading stuff (like the behavior if you click on a picture and it is not loaded instantly) since the button actually changes its style on click.

Actions #3

Updated by mkittler almost 6 years ago

  • Status changed from New to In Progress
  • Assignee set to mkittler

Without tags there's nothing to select. So I just disable the drop-down menu in this case to avoid confusion (button is now disabled and gray, and there's no arrow icon).

PR: https://github.com/os-autoinst/openQA/pull/1657

Actions #4

Updated by mkittler almost 6 years ago

  • Status changed from In Progress to Resolved

PR merged

Actions #5

Updated by coolo over 5 years ago

  • Target version changed from Ready to Done
Actions

Also available in: Atom PDF