action #35206

Needle selection disfunctional on screenshots without tags

Added by nicksinger almost 2 years ago. Updated over 1 year ago.

Status:ResolvedStart date:19/04/2018
Priority:NormalDue date:
Assignee:mkittler% Done:

0%

Category:Concrete Bugs
Target version:Done
Difficulty:
Duration:

Description

In the new version of OpenQA (4.5.1524056562.74e334c1), it can happen that the needle selection is clickable but nothing appears - e.g.: https://openqa.suse.de/tests/1628297#step/kdump_and_crash/20
I suspect that this happens on every screenshot which has no tags.

This is pretty confusing and not the most pretty thing. IMHO the candidate selection should be disabled if there is no content.

History

#1 Updated by coolo almost 2 years ago

  • Category set to Concrete Bugs
  • Target version set to Ready

Before there was '-None-' the only choice in a combobox - https://openqa.opensuse.org/tests/658456#step/logs_from_installation_system/20

#2 Updated by nicksinger almost 2 years ago

This was a little more obvious - even though not perfect ;)
As I already wrote, I'd suggest to just disable the button (and maybe change its text a little) if no content is available. Then it is grayed out and more obvious that there is no content to expect when you click on it.
Right now, it feels a little bit as if openQA is still loading stuff (like the behavior if you click on a picture and it is not loaded instantly) since the button actually changes its style on click.

#3 Updated by mkittler almost 2 years ago

  • Status changed from New to In Progress
  • Assignee set to mkittler

Without tags there's nothing to select. So I just disable the drop-down menu in this case to avoid confusion (button is now disabled and gray, and there's no arrow icon).

PR: https://github.com/os-autoinst/openQA/pull/1657

#4 Updated by mkittler almost 2 years ago

  • Status changed from In Progress to Resolved

PR merged

#5 Updated by coolo over 1 year ago

  • Target version changed from Ready to Done

Also available in: Atom PDF