Project

General

Profile

Actions
Copy link

action #34978

closed

Make log output of isotovideo fancier on manual calls, e.g. bring back colored output

Added by okurz over 6 years ago. Updated over 4 years ago.

Status:
Resolved
Priority:
Low
Assignee:
okurz
Category:
Feature requests
Target version:
QA (public) - future
Start date:
2018-04-15
Due date:
% Done:

0%

Estimated time:

Description

https://github.com/os-autoinst/os-autoinst/pull/876 changed the log format to be more standardized but also added more content and removed colored out. Would be nice to have that functionality back for the ones calling isotovideo manually.

Related issues 1 (0 open — 1 closed)

Related to openQA Project (public) - action #68146: Implement colored and interactive logsResolvedokurz2020-06-16

Actions
Actions
Copy link
 #1

Updated by coolo over 6 years ago

  • Subject changed from Make log output of isotovideo usable again on manual calls to Make log output of isotovideo fancier on manual calls
  • Target version set to future

It's usuable

Actions
Copy link
 #2

Updated by okurz over 6 years ago

  • Target version changed from future to future
Actions
Copy link
 #3

Updated by okurz almost 5 years ago

  • Status changed from New to Feedback
  • Assignee set to okurz

Some improvement in this direction: https://github.com/os-autoinst/os-autoinst/pull/1351

Actions
Copy link
 #4

Updated by okurz almost 5 years ago

  • Subject changed from Make log output of isotovideo fancier on manual calls to Make log output of isotovideo fancier on manual calls, e.g. bring back colored output
  • Status changed from Feedback to Workable
  • Assignee deleted (okurz)

merged and deployed already on o3. Looks like:

[2020-02-20T20:33:01.320 CET] [debug] tests/installation/bootloader.pm:57 called bootloader_setup::bootmenu_default_params -> lib/bootloader_setup.pm:468 called utils::type_string_very_slow -> lib/utils.pm:447 called testapi::type_string
[2020-02-20T20:33:01.320 CET] [debug] <<< testapi::type_string(string=" Y2DEBUG=1 vga=791 video=1024x768 plymouth.ignore-serial-consoles console=ttyS0 console=tty linuxrc.log=/dev/ttyS0 linuxrc.core=/dev/ttyS0 linuxrc.debug=4,trace reboot_timeout=0 ", max_interval=4, wait_screen_changes=0, wait_still_screen=0, timeout=30, similarity_level=47)
[2020-02-20T20:34:39.043 CET] [debug] tests/installation/bootloader.pm:57 called bootloader_setup::bootmenu_default_params -> lib/bootloader_setup.pm:468 called utils::type_string_very_slow -> lib/utils.pm:453 called testapi::wait_still_screen

Would be nice to get colored output back when isotovideo outputs on a real console.

Actions
Copy link
 #5

Updated by asmorodskyi almost 5 years ago

after latest changes we have this :

[2020-02-24T01:39:44.318 UTC] [debug] tests/installation/logpackages.pm:32 called testapi::script_run
[2020-02-24T01:39:44.318 UTC] [debug] <<< testapi::script_run(cmd="(cat /.timestamp ; echo /.packages.initrd: ; cat /.packages.initrd) > /dev/ttyS0", timeout=undef, quiet=undef, output="")
[2020-02-24T01:39:44.318 UTC] [debug] tests/installation/logpackages.pm:32 called testapi::script_run
[2020-02-24T01:39:44.318 UTC] [debug] <<< testapi::type_string(string="(cat /.timestamp ; echo /.packages.initrd: ; cat /.packages.initrd) > /dev/ttyS0", max_interval=250, wait_screen_changes=0, wait_still_screen=0, timeout=30, similarity_level=47)
[2020-02-24T01:39:47.139 UTC] [debug] tests/installation/logpackages.pm:32 called testapi::script_run
[2020-02-24T01:39:47.139 UTC] [debug] <<< testapi::type_string(string="; echo IsRws-\$?- > /dev/ttyS0\n", max_interval=250, wait_screen_changes=0, wait_still_screen=0, timeout=30, similarity_level=47)
[2020-02-24T01:39:48.270 UTC] [debug] tests/installation/logpackages.pm:32 called testapi::script_run
[2020-02-24T01:39:48.271 UTC] [debug] <<< testapi::wait_serial(expect_not_found=0, regexp=qr/IsRws-\d+-/, buffer_size=undef, record_output=undef, no_regex=0, quiet=undef, timeout=30)

took from here https://openqa.opensuse.org/tests/1184493/file/autoinst-log.txt

Actions
Copy link
 #6

Updated by okurz over 4 years ago

  • Priority changed from Normal to Low
Actions
Copy link
 #7

Updated by okurz over 4 years ago

  • Status changed from Workable to In Progress
  • Assignee set to okurz

once again I was trying to debug an issue and struggled to find the right lines. I want colors back! :) I have some ideas what we could do, for a start use https://metacpan.org/pod/Mojo::Log::Colored if available. And possibly bring back colors as we had originally in os-autoinst until https://github.com/os-autoinst/os-autoinst/pull/876 removed it for a reason I still do not understand.

Created a submission https://build.opensuse.org/request/show/805622 for Mojo::Log::Colored from d:l:p:CPAN-M to d:l:p . Equivalent for Term::ANSIColor with https://build.opensuse.org/request/show/805623

Actions
Copy link
 #8

Updated by okurz over 4 years ago

  • Status changed from In Progress to Feedback
Actions
Copy link
 #9

Updated by okurz over 4 years ago

  • Status changed from Feedback to Resolved

https://github.com/os-autoinst/os-autoinst/pull/1403 merged. So manual calls of isotovideo are fancy again :) Further ideas but out of scope for this ticket: Color Mojo::Log output of openQA in general, provide coloring in a custom log viewer on openQA

Actions
Copy link
 #10

Updated by okurz about 4 years ago

  • Related to action #68146: Implement colored and interactive logs added
Actions
Copy link

Also available in: Atom PDF