action #30246
closed
[sle][functional][autoyast][yast][hard] Improve variable expansion mechanism
Added by riafarov over 6 years ago.
Updated about 6 years ago.
Category:
Enhancement to existing tests
Description
As part of #28349 we start using modified profiles and expanding variables.
For the profiles which are available in the os-autoinst-distri repo we use openQA functionality to modify and upload files.
For the profiles in aytests repo we use cgi apache script, but it doesn't work well if we need to replace dynamic variables which are available in the job only. Hence as first step, we ave implemented cheap solution to replace values using sed on the support server, see https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/4193
Downloading profile and using same code as for profiles in os-autoinst-distri repo didn't work well as profiles are not available immediately, using locks didn't help and requires more investigation.
Alternative solution could be to use github url directly and get rid of support server when it's not required.
Acceptance criteria¶
- AC1 Variables expansion is done in one place
- Related to action #28349: [sle][functional] Use registration in autoinst profiles for sle 15 added
- Description updated (diff)
- Due date set to 2018-02-13
- Target version set to Milestone 14
schedule for one of the next sprints to not loose the momentum.
- Due date changed from 2018-02-13 to 2018-02-27
not loose the momentum but not for the current sprint. We agreed on focussing on fixing stuff rather adding more.
- Subject changed from [sle][functional][autoyast] Improve variable expansion mechanism to [sle][functional][autoyast][yast] Improve variable expansion mechanism
- Status changed from New to Workable
- Subject changed from [sle][functional][autoyast][yast] Improve variable expansion mechanism to [sle][functional][autoyast][yast][hard] Improve variable expansion mechanism
- Priority changed from Normal to Low
- Status changed from Workable to Rejected
So having a single place where we do variable expansion didn't work well. Idea was to get file content from support_server before starting child VM and then reupload it using workers mojolicious server. However, for multimachine setup we don't have routes configured to access support server http from outside, so it's not guaranteed to be there on the workers. Hence we have to keep this expansion in 2 places, and expanding MAC address is not possible other way as it not available before support server is contacted. So with this PR moving everything that can be done statically to one place and will have to continue using cgi for some cases like MAC. AC cannot be reached in short term. Considering priority - reject.
https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/4462
Also available in: Atom
PDF