action #29447
closed
[opensuse][functional][medium] Enhance salt test (no sleep, no fail on bsc#1069711)
Added by JERiveraMoya over 6 years ago.
Updated over 6 years ago.
Category:
Enhancement to existing tests
Description
Salt was failing in several scenarios and with PR https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/4079 we have tried to introduce a delay in communication client-server.
Once is merged if OSD displays successful results, try to improve this test using library functions and search for the specific file (the public key stored in the master) instead of sleep the machine.
Acceptance criteria¶
- AC1: salt-test does not use
sleep at all or with no value over 1s
- AC2: salt-test does not fail on bsc#1069711 (passes or soft-fail)
- AC3: No sporadic failure
Further details¶
Our most standard scenario gnome@64bit shows errors and sporadic behaviour so it should be easy to use this scenario for verification.
- Subject changed from [opensuse][functional] extra_tests_in_textmode@64bit salt failed to [opensuse][functional] extra_tests_in_textmode@64bit Enhance salt test
- Copied to action #29583: [opensuse][functional] extra_tests_in_textmode@64bit Fix salt test added
- Subject changed from [opensuse][functional] extra_tests_in_textmode@64bit Enhance salt test to [opensuse][functional][medium] Enhance salt test (no sleep, no fail on bsc#1069711)
- Description updated (diff)
- Due date set to 2018-02-13
- Status changed from New to Workable
- Target version changed from Milestone 12 to Milestone 13
- Status changed from Workable to Blocked
Ticket originally created to enhanced salt test ONLY if the workaround already present are effective, and they aren't. There are a couple of failure, we can replace the sleep for searching a file, but it is not needed because the sleep is working 100% and we just need to check later if the bug is solved with the current code. For the second error, pinging the minion we need to wait for the bug to be solve for sure.
It is kind of my fault to have created this enhancement test prematurely, because there is no need to enhance the code until the bug is fixed.
My recommendation is put it on hold and if developers recommend some kind of timeout, then do the improvement and search for the file, but if not it should work as it was working with python 2 without any delay.
- Status changed from Blocked to In Progress
- Assignee set to JERiveraMoya
- Status changed from In Progress to Feedback
PR merged, we have so many failed jobs on salt I guess it can only get better :)
- Status changed from Feedback to In Progress
- Status changed from In Progress to Resolved
Also available in: Atom
PDF