action #29447
closed[opensuse][functional][medium] Enhance salt test (no sleep, no fail on bsc#1069711)
0%
Description
Salt was failing in several scenarios and with PR https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/4079 we have tried to introduce a delay in communication client-server.
Once is merged if OSD displays successful results, try to improve this test using library functions and search for the specific file (the public key stored in the master) instead of sleep the machine.
Acceptance criteria¶
- AC1: salt-test does not use
sleepat all or with no value over 1s - AC2: salt-test does not fail on bsc#1069711 (passes or soft-fail)
- AC3: No sporadic failure
Further details¶
Our most standard scenario gnome@64bit shows errors and sporadic behaviour so it should be easy to use this scenario for verification.
Updated by JERiveraMoya over 6 years ago
- Subject changed from [opensuse][functional] extra_tests_in_textmode@64bit salt failed to [opensuse][functional] extra_tests_in_textmode@64bit Enhance salt test
Updated by JERiveraMoya over 6 years ago
- Copied to action #29583: [opensuse][functional] extra_tests_in_textmode@64bit Fix salt test added
Updated by okurz about 6 years ago
- Subject changed from [opensuse][functional] extra_tests_in_textmode@64bit Enhance salt test to [opensuse][functional][medium] Enhance salt test (no sleep, no fail on bsc#1069711)
- Description updated (diff)
- Due date set to 2018-02-13
- Status changed from New to Workable
- Target version changed from Milestone 12 to Milestone 13
I guess we will need an improvement here soon considering that many tests fail in salt now due to a product bug https://bugzilla.opensuse.org/show_bug.cgi?id=1069711 but I assume we should enhance the test to soft-fail instead (at least if not make it pass).
Updated by JERiveraMoya about 6 years ago
- Status changed from Workable to Blocked
Ticket originally created to enhanced salt test ONLY if the workaround already present are effective, and they aren't. There are a couple of failure, we can replace the sleep for searching a file, but it is not needed because the sleep is working 100% and we just need to check later if the bug is solved with the current code. For the second error, pinging the minion we need to wait for the bug to be solve for sure.
It is kind of my fault to have created this enhancement test prematurely, because there is no need to enhance the code until the bug is fixed.
My recommendation is put it on hold and if developers recommend some kind of timeout, then do the improvement and search for the file, but if not it should work as it was working with python 2 without any delay.
Updated by JERiveraMoya about 6 years ago
- Status changed from Blocked to In Progress
Now there is a proposal to test: https://bugzilla.suse.com/show_bug.cgi?id=1069711#c11
Updated by JERiveraMoya about 6 years ago
Updated by JERiveraMoya about 6 years ago
- Status changed from In Progress to Feedback
Updated by okurz about 6 years ago
PR merged, we have so many failed jobs on salt I guess it can only get better :)
Updated by JERiveraMoya about 6 years ago
- Status changed from Feedback to In Progress
Looks good, https://openqa.suse.de/tests/1430296#step/salt/24 but better to wait until next build to ensure is ok.
Updated by okurz about 6 years ago
- Status changed from In Progress to Resolved
So in build 424.4 salt looks really bad: https://openqa.suse.de/tests/overview?arch=&failed_modules=salt&distri=sle&version=15&build=424.4&groupid=110# 38 jobs failed in salt so also the recent enhancements did not help. This is in all tested architectures aarch64, ppc64le, x86_64 and failing in a timeout of 300 seconds. I assume we can not do anything useful here for now. Let's track it in the bug. I will comment in the bug as well.