action #28501: [qam][sle][functional][sle15] yast2_lan_restart.pm - ! -s journal.log seems not working - openQA Tests - openSUSE Project Management Tool

Actions

Copy link

action #28501

closed

[qam][sle][functional][sle15] yast2_lan_restart.pm - ! -s journal.log seems not working

Added by zluo almost 7 years ago. Updated almost 7 years ago.

Status:

Resolved

Priority:

Normal

Assignee:

zluo

Category:

Bugs in existing tests

Target version:

Start date:

2017-11-28

Due date:

% Done:

Estimated time:

Difficulty:

Related issues 3 (0 open — 3 closed)

Actions

Copy link

Updated by zluo almost 7 years ago

compare http://e13.suse.de/tests/18#step/yast2_lan_restart/32
and http://e13.suse.de/tests/19#step/yast2_lan_restart/32

assert_script_run 'ip a' and script_run 'ip a' has different results.
But anyway later test died because of timed out for ip a.

Actions

Copy link

Updated by zluo almost 7 years ago

Related to action #25676: [sle][functional][sle15][medium] test fails in yast2_lan_restart because of "SuSEfirewall2" popup, blocking next tests added

Actions

Copy link

Updated by zluo almost 7 years ago

currect status:

! -s journal.log seems not working

http://e13.suse.de/tests/26#step/yast2_lan_restart/39

Actions

Copy link

Updated by zluo almost 7 years ago

Subject changed from [sle][functional][sle15] yast2_lan_restart.pm - timeout for assert_script_run 'ip a' to [sle][functional][sle15] yast2_lan_restart.pm - ! -s journal.log seems not working

Actions

Copy link

Updated by zluo almost 7 years ago

check this again:
If I don't assign devive to zone, send_key 'alt-n';

--
assert_screen([qw(yast2-lan-restart_firewall_active_warning yast2_closed_xterm_visible)], 120);
if (match_has_tag 'yast2-lan-restart_firewall_active_warning') {
send_key 'alt-n';
wait_still_screen;
send_key 'alt-n';
wait_still_screen;
send_key 'alt-o';

}¶

Then I will get timeout issue:
http://e13.suse.de/tests/35#step/yast2_lan_restart/30

But I saw configuration has been written anyway after popup about activated firewall... Might be we need to disable firewall at first?

Actions

Copy link

Updated by okurz almost 7 years ago

Category set to Bugs in existing tests
Status changed from New to In Progress

I don't know what could have caused the file update. I recommend to split the test module first and also try to reproduce and investigate manually.

Actions

Copy link

Updated by zluo almost 7 years ago

If systemctl stop firewalld is called at beginning, then popup won't show up, but it still failed becaues of:
Test died: command '[ ! -s journal.log ]' failed at /var/lib/openqa/share/tests/opensuse/tests/x11/yast2_lan_restart.pm line 71.

Please see:
http://e13.suse.de/tests/latest?arch=x86_64&version=15.0&machine=64bit&test=extra_tests_on_gnome&flavor=DVD&distri=opensuse#step/yast2_lan_restart/48

Actions

Copy link

Updated by zluo almost 7 years ago

http://e13.suse.de/tests/latest?arch=x86_64&version=15.0&machine=64bit&test=extra_tests_on_gnome&flavor=DVD&distri=opensuse#step/yast2_lan_restart/45

cat journal.log got wicked messages.

compare with successful run for sles 12 sp3:
https://openqa.suse.de/tests/1019970#step/yast2_lan_restart/35

journal.log is empty.

Actions

Copy link

Updated by zluo almost 7 years ago

filed issue:
https://bugzilla.suse.com/show_bug.cgi?id=1070578

Actions

Copy link

#10

Updated by zluo almost 7 years ago

I observed that if firewalld is running, then we will have a timeout issue for script_run "ip a".

Actions

Copy link

#11

Updated by zluo almost 7 years ago

Assignee set to zluo

nsinger and I will work together on this task for now

Actions

Copy link

#12

Updated by zluo almost 7 years ago

PR updated:

https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/3956

Actions

Copy link

#13

Updated by zluo almost 7 years ago

Related to action #29063: [opensuse][functional] yast2-lan-restart failed because of firewalld issue added

Actions

Copy link

#14

Updated by zluo almost 7 years ago

https://openqa.opensuse.org/tests/553243#step/yast2_lan_restart

fixed and verified

Actions

Copy link

#15

Updated by zluo almost 7 years ago

checking now after correction of needle "hardware_tab" which is mismatched:

https://openqa.suse.de/tests/1305374

Actions

Copy link

#16

Updated by zluo almost 7 years ago

created further needles which are missing on osd.

Actions

Copy link

#17

Updated by coolo almost 7 years ago

Subject changed from [sle][functional][sle15] yast2_lan_restart.pm - ! -s journal.log seems not working to [qam][sle][functional][sle15] yast2_lan_restart.pm - ! -s journal.log seems not working

But how is this code supposed to work on sle12?

     if ("$status" eq 'restart') {
         assert_script_run '[ -s journal.log ]';                       # journal.log size is greater than zero (network restarted)
     }
     if ((is_sle && !sle_version_at_least('15')) || (is_leap && !leap_version_at_least('15.0'))) {
         assert_script_run '[ ! -s journal.log ]';
     }

Either it's -s or ! -s - but you can't assert both.

Actions

Copy link

#18