Project

General

Profile

action #2630

obs_factory: finish porting the logic server-side and review the already moved

Added by ancorgs over 6 years ago. Updated about 6 years ago.

Status:
Resolved
Priority:
High
Assignee:
Target version:
Start date:
2014-06-05
Due date:
% Done:

100%

Estimated time:
10.00 h

Description

We need to finish moving to obs_factory the logic that is now in osc staging check.

The already moved logic needs review by somebody understanding it properly, to ensure that both implementation does exactly the same.

History

#1 Updated by ancorgs about 6 years ago

  • Description updated (diff)
  • Assignee set to coolo
  • Target version set to Staging sprint 11
  • Estimated time changed from 20.00 h to 10.00 h

Removed the "of course, that means writing some tests" part from the description and adjusting the estimated time according.

#2 Updated by ancorgs about 6 years ago

  • Status changed from New to In Progress
  • % Done changed from 0 to 70

Everything implemented. Now it's turn for an expert eye (in OBS internals) to review if everything is calculated in the proper way.

#3 Updated by coolo about 6 years ago

I couldn't find an obvious problem - but the openqa logic needs to change. for staging prj every single test failure is a problem.

old code:
Checking staging project: openSUSE:Factory:Staging:G
-- Project still neeeds attention
ant: missing reviews: opensuse-review-team
textinfo test failed: https://openqa.opensuse.org/tests/10752

new code:
-- Project openSUSE:Factory:Staging:G still neeeds attention

  • ant: Missing reviews: opensuse-review-team

And I would like to see the different reviewers. If there is one review missing by opensuse-review-team or two doesn't really matter on the overall page, but if there is also a repo checker review missing is important. And I guess we don't need to spell opensuse-review-team, but can have an icon for that group.

And I would like to see the many green boxes merged into one - only if there is a problem, show the number of broken packages or obsolete requests. If none is there, just a green box will do.

#4 Updated by ancorgs about 6 years ago

  • Status changed from In Progress to Resolved
  • Assignee changed from coolo to ancorgs
  • % Done changed from 70 to 100

https://github.com/openSUSE-Team/obs_factory/pull/9 fixes the lack of openQA details. I moved the rest of the comments to #2620 (since they are not exactly about gathering or calculating the info) and I'm closing this task.

Also available in: Atom PDF