Project

General

Profile

Actions

action #25712

closed

feature request for assert_and_click - define exact area for click

Added by zluo about 7 years ago. Updated over 5 years ago.

Status:
Rejected
Priority:
Normal
Assignee:
Category:
Feature requests
Target version:
-
Start date:
2017-10-02
Due date:
% Done:

0%

Estimated time:

Description

I have sometimes difficult to make needle for assert_and_click as following example:

https://openqa.opensuse.org/tests/496499#step/yast2_lang/11

It will be useful if I can define the exact point of mouse click, not always the default point at middle of a needle.
Thanks!


Related issues 1 (0 open1 closed)

Is duplicate of openQA Project (public) - action #49943: [tools] Add new needle match type: "click"Resolvedmkittler2019-04-03

Actions
Actions #1

Updated by okurz about 7 years ago

  • Category changed from 136 to Feature requests

Keep in mind that "assert_and_click" "clicks in the middle of the last match region as defined in the needle JSON file" as described in the documentation http://open.qa/api/testapi/#_assert_and_click so there are multiple options. In the yast2_lang example you showed I would simply cover a bit more left of the check box so that more of the right-hand label is covered. But I can imagine this is not obvious to everyone and also in some cases might still not be possible so I consider this ticket a valid feature request although of low value and high effort. @szarate I leave further triaging to you but I suggest "low" and "future" for now as long as not more details are planned within the feature regarding how integration into the openQA webUI needle editor can look like.

Actions #2

Updated by mkittler about 7 years ago

@okurz

regarding how integration into the openQA webUI needle editor can look like.

I think the first step would be enabling this in os-autoinst. Should not be more than attaching further meta data to the needle and using them in the click implementation. This feature could then already be used by editing the JSON manually. If the feature is useful enough, it could also be integrated in the web UI. Would be some JavaScript coding with the canvas, but doable of course.

as long as not more details are planned

You're right, I can think of two details which should be clarified:

  • I assume the coordinates must be relative to the area? I guess making it relative to the top-left corner of the area would be the easiest way to implement it.
  • Do we want a constraint that the point must be inside the area? Would make sense in the first place but might be annoying to implement in the web UI and decreases flexibility. So I'd say no.
Actions #3

Updated by okurz about 7 years ago

mkittler wrote:

  • I assume the coordinates must be relative to the area? I guess making it relative to the top-left corner of the area would be the easiest way to implement it.

yes, exactly.

  • Do we want a constraint that the point must be inside the area? Would make sense in the first place but might be annoying to implement in the web UI and decreases flexibility. So I'd say no.

To think of an easy implementation webUI wise I think of drawing up another small area - possibly just in another color - within an existing matching area which gets linked to the match area to show where to click.

Actions #4

Updated by szarate almost 7 years ago

  • Assignee deleted (szarate)
Actions #5

Updated by okurz over 5 years ago

  • Is duplicate of action #49943: [tools] Add new needle match type: "click" added
Actions #6

Updated by okurz over 5 years ago

  • Status changed from New to Rejected
  • Assignee set to okurz
Actions

Also available in: Atom PDF