action #2388
closedWrong error message related with md5
Added by aplanas almost 10 years ago. Updated almost 10 years ago.
0%
Description
This error message is wrong:
231801 was declined with a misleading error. "Base:System/systemd-mini is a link but has a different md5sum than systemd"
Need to be changed, in this case, to
"systemd-mini is no longer the submitted version, please resubmit HEAD"
Unfortunately it's not so easy to differ the two situations, one solution is to check if you saw the "right" md5 once
Updated by aplanas almost 10 years ago
Uhmm I think that I do not understand this at the end.
In the example, the SR is referencing the source:
https://api.opensuse.org/source/Base:System/systemd/?expand=1&rev=609
and one of the spec file is referencing:
https://api.opensuse.org/source/Base:System/systemd-mini/?expand=1
As I see in the code, the check is comparing the srcmd5 of the first URL (I guest that is the MD5 of the source package for this 609 revision that the SR was based on), with the srcmd5 of the linkinfo entry of the second URL. But I can't never make it both equals changing the &rev= param in both URL. So clearly I do not understand the problem.
Updated by coolo almost 10 years ago
- Status changed from Feedback to New
The story is this:
we know what revision is submitted of systemd (609) - so we can get the srcmd5: aa8f80b0f345d6080502942106728b1e
and so we can dig into the jobhistory and find this:
<jobhist package="systemd" rev="609" srcmd5="aa8f80b0f345d6080502942106728b1e" versrel="210-646" bcnt="1" readytime="1398676911" starttime="1398676920" endtime="1398677848" code="succeeded" uri="http://192.168.1.124:60907" workerid="build24:9" hostarch="x86_64" reason="source change" verifymd5="089273015fa57b6b51bcb2b1ebe3896c" />
so we know it built - and we possibly can even download that md5sum's binaries (by comparing the disturl after download)
But we can't do that the same for 2nd spec files as the relation between 609 to srcmd5 is lost - and we need to verify that 609's systemd-mini actually succeeded too.
What you can do is looking at the jobhistory and what you'll find is that the readytime gives it away (in this special case!) that this is the right entry:
<jobhist package="systemd-mini" rev="5" srcmd5="120b7d1a9e61cb4a8320801109132eab" versrel="210-646" bcnt="1" readytime="1398676911" starttime="1398676914" endtime="1398677687" code="succeeded" uri="http://192.168.1.121:49463" workerid="build21:1" hostarch="x86_64" reason="source change" verifymd5="089273015fa57b6b51bcb2b1ebe3896c" />
and indeed if you look at /source/Base:System/systemd-mini/?expand=1&rev=120b7d1a9e61cb4a8320801109132eab you will find
<linkinfo project="Base:System" package="systemd" srcmd5="aa8f80b0f345d6080502942106728b1e" lsrcmd5="4c7aa0853505c3c33717ff31077dabe9" />
which is indeed the submitted systemd package.
But the code right now avoids that backtracking and only checks if the currently submitted systemd package is the same as systemd-mini. Once that systemd is changed, systemd-mini's HEAD will no longer match to the submitted request and it will be declined. With backtracking it would be better.
Updated by aplanas almost 10 years ago
- Status changed from New to Resolved
Updated by aplanas almost 10 years ago
- Status changed from Resolved to In Progress
Hi,
I thought that this error is gone?
Greetings, Stephan
-------- Original Message --------
Subject: Request 233813 changed to declined (submit
openSUSE:Factory/kernel-source)
Date: Wed, 14 May 2014 08:37:39 +0200
From: Factory Repo Checker factory-repo-checker@kulow.org
To: Stephan Kulow coolo@suse.com
Visit https://build.opensuse.org/request/show/233813
State of request 233813 was changed by factory-repo-checker:
review -> declined
Comment:
Kernel:stable/kernel-debug is a link but has a different md5sum than
kernel-source?
Actions:
- submit Kernel:stable/kernel-source => openSUSE:Factory/kernel-source
Updated by aplanas almost 10 years ago
- Status changed from In Progress to Resolved
Updated by aplanas almost 10 years ago
- Status changed from Resolved to In Progress
Reopened again:
This is getting a bit embarrassing ;(
Greetings, Stephan
-------- Original-Nachricht --------
Betreff: Request 234961 changed to declined (submit
openSUSE:Factory/systemd)
Datum: Wed, 21 May 2014 16:38:07 +0200
Von: Factory Repo Checker factory-repo-checker@kulow.org
An: Stephan Kulow coolo@suse.com, John Jolly jjolly@suse.com, "Dr.
Werner Fink" werner@suse.com, Frederic Crozat fcrozat@suse.com,
Robert Milasan rmilasan@suse.com, systemd maintainers
systemd-maintainers@suse.de
Visit https://build.opensuse.org/request/show/234961
State of request 234961 was changed by factory-repo-checker:
review -> declined
Comment:
Base:System/systemd-mini is a link but has a different md5sum than
systemd?
Updated by aplanas almost 10 years ago
- Status changed from In Progress to Resolved