action #181808
closedcoordination #162539: [saga][epic] future ideas version for version control features within openQA
coordination #181886: [epic] Good git defaults for new instances while keeping compatibility for old instances
Needle saving in editor broken if git features are disabled size:S
Description
I think since 015e1151b639c707780d4af232e5fa8e69710957 , which was part of fixing https://progress.opensuse.org/issues/164898 , saving needles in the editor is broken if you don't have git enabled. When I try and do it, I get the error "Fatal error when saving needle. Another git task is ongoing. Try again later." But there is no git task ongoing, obviously, because git is disabled.
I think this is because with git disabled, guards are created but never cleared? But I have to admit I'm not 100% sure how the guards were cleared before. I can find code for creating them, but I don't see how they get...uncreated?
Updated by mkittler 14 days ago
- Status changed from New to Feedback
This seems to work fine with Git support disabled on my local setup. It also works with scm = git uncommented but other options under [scm git] disabled. In this case a Git commit is created and the Minion job is still not stuck waiting on any other Git operations to finish.
Maybe you have a stale lock on your setup? You can check this on http://localhost/minion/locks which should show an empty list (unless there's an active Minion job which has acquired a lock, then the list is supposed be become empty when all active jobs have been processed).
Updated by AdamWill 11 days ago ยท Edited
- Status changed from Feedback to Closed
yeah, sorry if my previous comment wasn't clear enough: this was all on my end, I mistakenly wound up with a package installed that had a bad version of my big git patch set, and that was causing the problem.
well, in a way, it's not totally just my fault - the bug happens if openQA is trying to do Git Stuff to the distri, but it can't for whatever reason (the distri is not a git repo, or openQA doesn't have permissions to write to the distri, for instance). These guards seem to hang around in that case. In this case the git operations were happening because git_auto_update is enabled by default, which I feel is wrong, and I'm proposing to turn off in https://github.com/os-autoinst/openQA/pull/6472 .