Project

General

Profile

Actions

action #179975

open

coordination #127031: [saga][epic] openQA for SUSE customers

coordination #168127: [epic] Up-to-date Perl stack

perlcritic openQA - Check more than just lib/ and use Perl::Critic::TooMuchCode

Added by tinita 22 days ago. Updated 22 days ago.

Status:
Blocked
Priority:
Low
Assignee:
Category:
Feature requests
Target version:
Start date:
2025-04-03
Due date:
% Done:

0%

Estimated time:

Description

Motivation

We use a common code style for all our perl code.

TooMuchCode::ProhibitUnusedImport can check for unused module imports.
It also has ProhibitExtraStricture which seems better than our own implementation.

Acceptance criteria

  • AC1: openQA perlcritic checks cover all directories with perl code
  • AC2: We use the policies from Perl::Critic::TooMuchCode
  • AC3: Superfluous implementations in os-autoinst-common are removed

Suggestions


Related issues 1 (1 open0 closed)

Copied from openQA Project (public) - action #155191: Unify GitHub Actions for QA Projects - perlcritic in os-autoinstNew2023-10-24

Actions
Actions #1

Updated by tinita 22 days ago

  • Copied from action #155191: Unify GitHub Actions for QA Projects - perlcritic in os-autoinst added
Actions #2

Updated by tinita 22 days ago

  • Description updated (diff)
Actions #3

Updated by tinita 22 days ago

  • Description updated (diff)
Actions #4

Updated by okurz 22 days ago

  • Parent task changed from #96596 to #168127
Actions #5

Updated by okurz 22 days ago

  • Status changed from New to Blocked
  • Assignee set to okurz
  • Target version set to Ready
Actions #6

Updated by okurz 22 days ago

accepted. osc mr -m "Useful module for style checks we want to use for openQA" openSUSE:Factory perl-Perl-Critic-TooMuchCode openSUSE:Backports:SLE-15-SP6:Update

-> https://build.opensuse.org/requests/1266955

Actions

Also available in: Atom PDF