Project

General

Profile

Actions
Copy link

action #179975

open

coordination #127031: [saga][epic] openQA for SUSE customers

coordination #182387: [epic] More advanced Perl practices and packages to be future-proof

perlcritic openQA - Check more than just lib/ and use Perl::Critic::TooMuchCode

Added by tinita about 2 months ago. Updated about 13 hours ago.

Status:
New
Priority:
Low
Assignee:
-
Category:
Feature requests
Target version:
QA (public) - future
Start date:
2025-04-03
Due date:
% Done:

0%

Estimated time:

Description

Motivation

We use a common code style for all our perl code.

TooMuchCode::ProhibitUnusedImport can check for unused module imports.
It also has ProhibitExtraStricture which seems better than our own implementation.

Acceptance criteria

  • AC1: openQA perlcritic checks cover all directories with perl code
  • AC2: We use the policies from Perl::Critic::TooMuchCode
  • AC3: Superfluous implementations in os-autoinst-common are removed

Suggestions

Related issues 1 (1 open — 0 closed)

Copied from openQA Project (public) - action #155191: Unify GitHub Actions for QA Projects - perlcritic in os-autoinstNew2023-10-24

Actions
Actions
Copy link
 #1

Updated by tinita about 2 months ago

  • Copied from action #155191: Unify GitHub Actions for QA Projects - perlcritic in os-autoinst added
Actions
Copy link
 #2

Updated by tinita about 2 months ago

  • Description updated (diff)
Actions
Copy link
 #3

Updated by tinita about 2 months ago

  • Description updated (diff)
Actions
Copy link
 #4

Updated by okurz about 2 months ago

  • Parent task changed from #96596 to #168127
Actions
Copy link
 #5

Updated by okurz about 2 months ago

  • Status changed from New to Blocked
  • Assignee set to okurz
  • Target version set to Ready
Actions
Copy link
 #6

Updated by okurz about 2 months ago

accepted. osc mr -m "Useful module for style checks we want to use for openQA" openSUSE:Factory perl-Perl-Critic-TooMuchCode openSUSE:Backports:SLE-15-SP6:Update

-> https://build.opensuse.org/requests/1266955

Actions
Copy link
 #7

Updated by okurz 11 days ago

  • Status changed from Blocked to Feedback
  • Target version changed from Ready to future

https://build.opensuse.org/requests/1266955 was accepted but https://build.opensuse.org/package/show/openSUSE:Maintenance:18856/perl-Perl-Critic-TooMuchCode.openSUSE_Backports_SLE-15-SP6_Update looks like it's still open with

unresolvable: nothing provides perl(List::Util) >= 1.50, (got version 1.46_02 provided by perl-base-32bit), (got version 1.46_02 provided by perl-base), (got version 1.49 provided by perl-Scalar-List-Utils), nothing provides perl(Module::Build::Tiny) >= 0.39.0, (got version 0.039 provided by perl-Module-Build-Tiny), nothing provides perl(Scalar::Util) >= 1.50, (got version 1.46_02 provided by perl-base-32bit), (got version 1.46_02 provided by perl-base), (got version 1.49 provided by perl-Scalar-List-Utils)

so I assume this can't work for Leap 15 due to an older perl-base?

Actions
Copy link
 #8

Updated by okurz 11 days ago

  • Status changed from Feedback to New
  • Assignee deleted (okurz)
  • Parent task changed from #168127 to #182387
Actions
Copy link
 #9

Updated by tinita about 13 hours ago ยท Edited

For the perl-Module-Build-Tiny dependency the following request should fix that:
https://build.opensuse.org/requests/1279870

For List::Util and Scalar::Util we would have to submit the latest perl-Scalar-List-Utils to Leap as well.

edit: and looking at the changelog for 1.50, it seems to e a good idea anyway.

Actions
Copy link

Also available in: Atom PDF