QA (public) » openQA Project (public)

action #179975

Updated by tinita 23 days ago

## Motivation 

 We use a common code style for all our perl code. 

 [TooMuchCode::ProhibitUnusedImport](https://metacpan.org/pod/Perl::Critic::Policy::TooMuchCode::ProhibitUnusedImport) can check for unused module imports. 
 It also has [ProhibitExtraStricture](https://metacpan.org/pod/Perl::Critic::Policy::TooMuchCode::ProhibitExtraStricture) which seems better than our own implementation. 

 ## Acceptance criteria 
 * **AC1:** openQA perlcritic checks cover all directories with perl code 
 * **AC2:** We use the policies from `Perl::Critic::TooMuchCode` 
 * **AC3:** Superfluous implementations in [os-autoinst-common](https://github.com/os-autoinst/os-autoinst-common) os-autoinst-common are removed 

 ## Suggestions 
 * perl-Perl-Critic-TooMuchCode is currently being submitted to factory: https://build.opensuse.org/requests/1266850 
   It might have to be submitted to Leap additionally.

Back