Do not upload empty serial_terminal.txt file
If serial_terminal.txt file is empty then it should not be uploaded.
Updated by rpalethorpe over 6 years ago
- Assignee deleted (
This is not going very well.
Basically, QEMU creates this log file as soon as it starts up on all tests where virtio terminal is enabled, which is all machines that support it. As far as I can tell there is no good way to only configure it for tests which use it, unless perhaps it can be done through worker classes, but I don't know how to configure them.
I think os-autoinst could delete it before upload, but this hides the backend's behaviour and it is simply unnecessary from os-autoinsts point of view.
It is quite simple to not show it in the OpenQA UI, but testing its behaviour is a problem. I'm not familiar enough with the integration/unit tests in the OpenQA UI to figure out a good solution and the suggested solution seems dangerous to me so I am abdicating. Sorry.
Obviously I have no issue with the file being hidden if it is empty, unless some other user complains this hides QEMU's behaviour.