QA (public) » openQA Project (public)

Observation¶

When I run t/24-worker-overall.t I see a new directory t/pool5J9L in my git worktree.
If I run this test many times, new directories are created over and over.

I also had a look at other tests and found t/24-worker-engine.t and t/24-worker-jobs.t which are creating a tempdir under the git worktree.

my $pool_directory = tempdir('poolXXXX');

We should avoid doing this and use a directory under /tmp instead.
Yes, .gitignore has pool????/, but that doesn't mean I want 1000 of those directories lying around.

Acceptance Criteria¶

AC1: t/24-worker-* tests are creating their tempdirs under /tmp and not the git worktree.
AC2: The cleanup of the dirs in t/24-worker-overall.t is working.

Suggestions¶

There are two issues going on here:

• t/24-worker-overall.t creates a tempdir 3 times, but one of them is not cleaned up. I believe this is because the worker is still holding the pool dir lock when the cleanup is called. This should be fixed in any case, even if me move this under /tmp.
• for t/24-worker-engine.t and t/24-worker-jobs.t I see no leftover directories because they get cleaned up correctly. However, it could still happen that the test dies and it doesn't get cleaned up for some reason. We should be consistent and do not add or modify any files in git during tests.