Actions
action #177024
closed[beginner][easy][os-autoinst] t/10-virtio_terminal.t prove status line shows up as yellow size:S
Start date:
2025-02-12
Due date:
% Done:
0%
Estimated time:
Tags:
Description
Observation¶
See https://github.com/os-autoinst/os-autoinst/actions/runs/13267005662/job/37036860763#step:3:413
instead of grey as expected. There is likely some log output line in that test affecting the outer console that should be properly guarded
Acceptance criteria¶
- AC1: t/10-virtio_terminal.t prove output shows up in the usual color same as other tests
Suggestions¶
- Look into t/10-virtio_terminal.t or run it with
prove -v
to narrow down when the output color changes - Properly guard the output, e.g. with Test::Output calls or setting config variables on the log module or something
- Consider to fix t/23-baseclass.t https://github.com/os-autoinst/os-autoinst/actions/runs/13267005662/job/37036860763#step:3:430 and t/33-vagrant.t https://github.com/os-autoinst/os-autoinst/actions/runs/13267005662/job/37036860763#step:3:459 which are likely troubled by a very similar problem
- Run
prove -I . t/10-virtio_terminal.t -v
to see the individual tests that show up yellow to find the culprit(s)
Updated by livdywan 16 days ago
- Subject changed from [beginner][easy][os-autoinst] t/10-virtio_terminal.t prove status line shows up as yellow to [beginner][easy][os-autoinst] t/10-virtio_terminal.t prove status line shows up as yellow size:S
- Description updated (diff)
- Status changed from New to Workable
Updated by tinita 16 days ago
- Status changed from In Progress to Feedback
https://github.com/os-autoinst/os-autoinst/pull/2664 Fix log colors
Updated by okurz 15 days ago
- Status changed from Feedback to Resolved
https://github.com/os-autoinst/os-autoinst/actions/runs/13311802984/job/37175982430 looks very clean. All good
Actions