action #176886
closedcoordination #102915: [saga][epic] Automated classification of failures
QA (public) - coordination #94105: [epic] Use feedback from openqa-investigate to automatically inform on github pull requests, open tickets, weed out automatically failed tests
A "+" and other characters used in test names in $var are considered invalid in WORKER_CLASS:$var size:S
0%
Description
Observation¶
From #176418-10
tinita found in the osd gru journal:
Feb 10 14:05:23 openqa openqa-gru[31894]: openqa-clone-job (83 /opt/os-autoinst-scripts/openqa-investigate): (openqa-clone-job --json-output --skip-chained-deps --max-depth 0 --parental-inheritance --within-instance https://openqa.suse.de/tests/16675956 _TRIGGER_JOB_DONE_HOOK=1 _GROUP_ID=0 BUILD= CASEDIR=https://github.com/os-autoinst/os-autoinst-distri-opensuse.git#99328f722c5266d87384cb7ffb78ab18bc7fba33 WORKER_CLASS:wsl2-main+systemd=qemu_x86_64,qemu_x86_64_staging,qemu_x86_64-large-mem,tap_secondary,windows11,wsl2,platform_intel,zone-cc,region-prg,datacenter-prg1,location-prg_office,openqaworker14,cpu-x86_64,cpu-x86_64-v2,cpu-x86_64-v3,cpu-x86_64-v4 TEST+=:investigate:last_good_tests_and_build:99328f722c5266d87384cb7ffb78ab18bc7fba33+3.76 OPENQA_INVESTIGATE_ORIGIN=https://openqa.suse.de/t16710107) stderr: >>>command-line argument 'WORKER_CLASS:wsl2-main+systemd=qemu_x86_64,qemu_x86_64_staging,qemu_x86_64-large-mem,tap_secondary,windows11,wsl2,platform_intel,zone-cc,region-prg,datacenter-prg1,location-prg_office,openqaworker14,cpu-x86_64,cpu-x86_64-v2,cpu-x86_64-v3,cpu-x86_64-v4' is no valid setting and will be ignored<<<
WORKER_CLASS:wsl2-main+systemd=...
It seems the + in the test name isn't expected:
https://github.com/os-autoinst/openQA/blob/master/lib/OpenQA/Script/CloneJob.pm#L42\
Acceptance criteria¶
- AC1: Allow all valid test names in scope settings as well (
SETTING:$testname=...) - AC2: Ensure the dependency between scopes and test names is clearly documented
Suggestions¶
- Consider the implication of using an allowlist vs a blocklist e.g. if test names can contain a < or & and end up pasted in a shell command-line
- Research relevant cases for the investigate script, which uses test names as worker classes
Our of scope¶
- Characters in TEST should match, but this is covered by #177267
Updated by okurz 18 days ago
- Copied from action #176418: last_good_tests_and_build is not triggered even though matching worker instance seems to be free and 0 jobs running due to jobs as part of parallel clusters added
Updated by tinita 17 days ago
https://github.com/os-autoinst/openQA/pull/6172 Allow plus signs in test names for scope settings
Updated by tinita 15 days ago
- Status changed from Resolved to Workable
Another instance of the error, but with different characters:
Feb 14 09:34:12 openqa openqa-gru[21447]: openqa-clone-job (83 /opt/os-autoinst-scripts/openqa-investigate): (openqa-clone-job --json-output --skip-chained-deps --max-depth 0 --parental-inheritance --within-instance https://openqa.suse.de/tests/16743916 _TRIGGER_JOB_DONE_HOOK=1 _GROUP_ID=0 BUILD= CASEDIR=https://github.com/os-autoinst/os-autoinst-distri-opensuse.git#6839230a63cf3774c9b8d5480bfcb37a12ad6937 WORKER_CLASS:open-webui_0.3_on_k8s=pc_azure_qac,worker29,cpu-x86_64,cpu-x86_64-v2,cpu-x86_64-v3 TEST+=:investigate:last_good_tests_and_build:6839230a63cf3774c9b8d5480bfcb37a12ad6937+7.22_open-webui-container OPENQA_INVESTIGATE_ORIGIN=https://openqa.suse.de/t16771333) stderr: >>>command-line argument 'WORKER_CLASS:open-webui_0.3_on_k8s=pc_azure_qac,worker29,cpu-x86_64,cpu-x86_64-v2,cpu-x86_64-v3' is no valid setting and will be ignored<<<
WORKER_CLASS:open-webui_0.3_on_k8s=pc_azure_qac,worker29,cpu-x86_64,cpu-x86_64-v2,cpu-x86_64-v3
So we should add the dot as well...
Updated by tinita 15 days ago
- Related to action #177267: Forbid unprintable characters, white space, colons, equal signs and quotes in TEST names size:S added
Updated by okurz 1 day ago
- Status changed from Feedback to Resolved
https://github.com/os-autoinst/openQA/pull/6221 merged. That should suffice now, right?