action #175111
closedcoordination #169654: [epic] Create test scenarios for Agama
Add CI check for agama profiles which are at json/jsonnet format
0%
Description
Description¶
Hello Yam experts, as discussed offline with @mgrifalconi and @leli, I filed this ticket, please feel free to re-assign if it is not under your test scope.
As sle16 agama installer uses json/jsonnet files. it should be great we have ci check for these files. it will help us to make sure the files are usable [at least on obvious format/style issues]
More detail can be found at https://suse.slack.com/archives/C02CSAZLAR4/p1736338956797719
We should use this before pushing the files to git: https://jsonnet.org/learning/tools.html. For Yam squad, we will focus on jsonnet exclusively for now, not sure about the use of json or other format at the moment.
Acceptance criteria¶
- AC1: Add CI check for agama profiles which are jsonnet format
Additional information¶
Get jsonnet-lint file.jsonnet in .github/workflows/ci.yml.
Some more detail info for discussion about it see https://suse.slack.com/archives/C02CLB2LB7Z/p1736393322298209
Updated by JERiveraMoya 3 months ago
we don't use [qe-yam] tag, we have a subproject in progress.
Do you have any idea where to start? or if there is precedent to check the xml for AutoYaST?
I guess you mean something like a linter.
Updated by rfan1 3 months ago · Edited
JERiveraMoya wrote in #note-1:
we don't use [qe-yam] tag, we have a subproject in progress.
Got it, I hope you can change the Project if yam team would like to pick up this ticket. :)
Do you have any idea where to start? or if there is precedent to check the xml for AutoYaST?
I guess you mean something like a linter.
Thank you for the update, I have a PR long time ago which may help a bit https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/16356.
Updated by JERiveraMoya 3 months ago
- Tags set to qe-yam-jan-sprint-fy25
- Status changed from New to Workable
- Priority changed from Normal to High
- Parent task set to #169654
Updated by JERiveraMoya 2 months ago
leli wrote in #note-5:
One thinking about the CI check, maybe we can have a simple transfer tool to make jsonnet to json, so we only need maintain jsonnet files.
yes, that is exactly the idea: https://progress.opensuse.org/issues/175728
Updated by JERiveraMoya about 2 months ago
- Tags changed from qe-yam-jan-sprint-fy25 to qe-yam-feb-sprint-fy25
Updated by JERiveraMoya about 2 months ago
we should sync with https://progress.opensuse.org/issues/175728 to know what we really plan to validate.
Updated by JERiveraMoya about 2 months ago
- Related to action #175728: Generate all Agama json profiles using jsonnet profiles for qemu added
Updated by leli about 2 months ago · Edited
Now we need install golang-github-google-jsonnet package via "https://download.opensuse.org/repositories/systemsmanagement:Agama:Devel/15.6/systemsmanagement:Agama:Devel.repo"
and we are waiting for the package built for all other architectures (s390x/aarch64/ppc64le), it is better to add this CI check after it is in Salt repository.
Then we can use jsonnet-lint to validate the jsonnet profile during CI check.
Updated by leli about 2 months ago
Created a draft PR, https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/21168
Don't know how to run VR for this PR, create a temp jsonnet profile and make in local branch?
Updated by JERiveraMoya about 2 months ago
- Status changed from In Progress to Workable
Updated by JERiveraMoya about 2 months ago
Moving to workable but at the end of the list, so this will be done first:
https://suse.slack.com/archives/C02CANHLANP/p1733729839444069
Updated by JERiveraMoya about 2 months ago
- Status changed from Workable to In Progress
Updated by JERiveraMoya about 1 month ago
Moved back to in-progress as it should be workable, in ci we use ubuntu, different package name.
Updated by leli about 1 month ago
JERiveraMoya wrote in #note-17:
Moved back to in-progress as it should be workable, in ci we use ubuntu, different package name.
On ubuntu, I can get the pkg 'jsonnet', install it then can use jsonnet cmd to check jsonnet profile. I will update the PR.
Updated by JERiveraMoya 28 days ago
- Tags changed from qe-yam-feb-sprint-fy25 to qe-yam-mar-sprint-fy25
Updated by leli 18 days ago
The CI check issue https://github.com/os-autoinst/os-autoinst-distri-opensuse/actions/runs/13803221157/job/38609282351?pr=21168 shown 'Unable to locate package jsonnet'. CI check use container with image of debian 'buster' without pkg jsonnet, filed a PR https://github.com/Perl/docker-perl-tester/pull/73 to change it from 'buster' to 'bookworm' which has the pkg of jsonnet.
Updated by leli 10 days ago · Edited
This is the option 2 PR to install jsonnet via python, https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/21496
Updated by leli 7 days ago
- Related to action #179383: Enhance CI check for agama profiles for jsonnet format added