Project

General

Profile

Actions

action #167635

closed

coordination #154768: [saga][epic][ux] State-of-art user experience for openQA

coordination #154771: [epic] Improved test developer user experience

Needle Admin Interface shows wrong timestamps; t/ui/21-admin-needles.t can fail locally depending on time zone size:S

Added by tinita 3 months ago. Updated about 2 months ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
Regressions/Crashes
Target version:
Start date:
2024-09-30
Due date:
% Done:

0%

Estimated time:

Description

Observation

In the needle interface, e.g. https://openqa.opensuse.org/admin/needles one can observe that all "Last Use" and "Last Match" are at least 2 hours ago. That is, if your browser lives in CE(S)T.
But that is because the server returns the time without a timestamp, and the client thinks it's local time.
You can also go to the last openQA test, https://openqa.opensuse.org/tests/4522759#step/dashboard/5 and click on any needle and let you show the needle info by clinking on he little clock icon in the candidates list. You will see UTC timestamps there.

Related to that, on @tinita 's machine t/ui/21-admin-needles.t is failing with this:

ok 4 - Path is fixtures
ok 5 - Name is right
ok 6 - last use is right
not ok 7 - last match is right

#   Failed test 'last match is right'
#   at t/ui/21-admin-needles.t line 76.
#          got: 'about 12 hours ago'
#     expected: 'about 14 hours ago'
ok 8 - Path is fixtures
# more related errors later

Looking at the timestamps in the test data, 14 hours is actually correct. Maybe it also depends on the chromedriver timezone.

Acceptance criteria

  • AC1: The admin needles table displays durations (e.g. "X minutes ago") correctly (not adding e.g. 2 hours).

Suggestions

  • Check what has already been done in https://github.com/os-autoinst/openQA/pull/5964
  • The popup in the needle candidates menu should be closed before clicking to close the candidates manu again, because on some developer machines the test mentioned above is failing because the longer timestamp makes the popup too big

Related issues 1 (0 open1 closed)

Related to openQA Project (public) - action #164898: Replace fetchneedles with a minion job for the regular update of git repos size:MResolvedtinita

Actions
Actions #1

Updated by okurz 3 months ago

  • Parent task set to #154771
Actions #2

Updated by tinita 3 months ago

The test can locally be fixed by adding:

BEGIN { $ENV{TZ} = 'UTC' }

See https://github.com/os-autoinst/openQA/commit/2701fe58ee84330ec763193ba7af20f45aa2b0a4 where the same was done for t/ui/16-activity-view.t 4 years ago.

Actions #3

Updated by tinita 3 months ago ยท Edited

  • Priority changed from High to Normal

https://github.com/os-autoinst/openQA/pull/5965 Make t/ui/21-admin-needles.t work for every timezone

With that the prio not High anymore as it is not blocking my other task.

Draft: https://github.com/os-autoinst/openQA/pull/5964 Return timestamps with offset to client for needle info

Actions #4

Updated by livdywan 3 months ago

  • Related to action #164898: Replace fetchneedles with a minion job for the regular update of git repos size:M added
Actions #5

Updated by okurz 2 months ago

  • Subject changed from Needle Admin Interface shows wrong timestamps; t/ui/21-admin-needles.t can fail locally depending on time zone to Needle Admin Interface shows wrong timestamps; t/ui/21-admin-needles.t can fail locally depending on time zone size:S
  • Description updated (diff)
  • Status changed from New to Workable
Actions #6

Updated by dheidler 2 months ago

  • Status changed from Workable to In Progress
  • Assignee set to dheidler
Actions #7

Updated by openqa_review 2 months ago

  • Due date set to 2024-10-26

Setting due date based on mean cycle time of SUSE QE Tools

Actions #8

Updated by dheidler 2 months ago

  • Status changed from In Progress to Feedback
Actions #9

Updated by dheidler about 2 months ago

  • Status changed from Feedback to Resolved
Actions #10

Updated by okurz about 2 months ago

  • Due date deleted (2024-10-26)
Actions

Also available in: Atom PDF