Project

General

Profile

Actions

action #164811

closed

coordination #58184: [saga][epic][use case] full version control awareness within openQA

coordination #48641: [epic] Trigger openQA tests in pull requests of any product github pull request

Attempt to run job with non-existant git branch specified in CASEDIR will not fail with clear error size:S

Added by asmorodskyi 2 months ago. Updated 2 months ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
Regressions/Crashes
Target version:
Start date:
2024-08-01
Due date:
% Done:

0%

Estimated time:

Description

Observation

Clone job with not existing branch for CASEDIR=https://github.com/asmorodskyi/os-autoinst-distri-opensuse.git#zypperlog ( IMPORTANT NOTE : my fork has branch zypper.log (with a dot) but there is NO branch zypperlog ( NO dot )
==> there is no failure which would clearly state that openQA failed to checkout the branch , it "successfully" cloning something but I failed to understand what repo state was cloned after all and I can say for sure that test behavior is wrong and unexpected https://openqa.suse.de/tests/15052356#settings

(In attachment you may find os-autoinst log)

This looks like a regressio. https://openqa.suse.de/tests/15052356/logfile?filename=autoinst-log.txt clearly states:

[2024-08-01T11:55:44.578369+02:00] [debug] [pid:9084] Clone failed, retries left: 2 of 2

but then just continues with

[2024-08-01T11:55:49.578961+02:00] [debug] [pid:9084] Skipping to clone 'https://github.com/asmorodskyi/os-autoinst-distri-opensuse.git'; os-autoinst-distri-opensuse already exists

Acceptance criteria

  • AC1: Obvious error message returned to user when a non-existing git branch is encountered

Suggestions

  • Try it yourself with just plain isotovideo to ensure that isotovideo already stops with an error to find out if the problem is within os-autoinst or openQA

Files

autoinst-log.txt (221 KB) autoinst-log.txt asmorodskyi, 2024-08-01 10:53
Actions #1

Updated by okurz 2 months ago

  • Tags set to reactive work
  • Project changed from openQA Tests to openQA Project
  • Description updated (diff)
  • Category changed from Bugs in existing tests to Regressions/Crashes
  • Target version set to Ready
  • Parent task set to #48641
Actions #2

Updated by okurz 2 months ago

  • Subject changed from Attempt to run job with wrong CASEDIR will not fail with clear error to Attempt to run job with non-existant git branch specified in CASEDIR will not fail with clear error size:S
  • Description updated (diff)
  • Status changed from New to Workable
Actions #3

Updated by mkittler 2 months ago

  • Status changed from Workable to In Progress
  • Assignee set to mkittler
Actions #4

Updated by mkittler 2 months ago

  • Status changed from In Progress to Feedback
Actions #5

Updated by mkittler 2 months ago

  • Status changed from Feedback to Resolved

The PR has been merged and deployed.

Actions

Also available in: Atom PDF