Project

General

Profile

Actions

action #164712

closed

Remove the deprecated "script_run($cmd, die_on_timeout => 0)" and handle follow-up size:M

Added by okurz 5 months ago. Updated 3 months ago.

Status:
Resolved
Priority:
Low
Assignee:
Category:
Feature requests
Target version:
Start date:
Due date:
% Done:

0%

Estimated time:

Description

Motivation

See #164541. script_run($cmd, die_on_timeout => 0) was declared deprecated some years ago. We should follow up by obsoleting and helping affected users (or revert the deprecation).

Acceptance criteria

  • AC1: The use case of starting a script, doing something else and finally waiting for the script to finish is still covered.
  • AC2: The use case of starting a script and handling a stall or timeout gracefully is still covered
  • AC3: No deprecated modes of script_run persist in testapi.pm

Suggestions

  • Review past decisions
  • Provide a change to osado to not have script_run($cmd, die_on_timeout => 0)
  • For AC2 it's suggested to use enter_cmd && wait_serial (which should be documented, e.g. a hint on the enter_cmd documentation explaining the possibility to chain with wait_serial would make sense)
Actions

Also available in: Atom PDF