Project

General

Profile

Actions

action #161969

closed

os-autoinst ustreamer tests fail on s390x (big-endian) size:S

Added by AdamWill 6 months ago. Updated 6 months ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
Regressions/Crashes
Target version:
Start date:
2024-06-07
Due date:
% Done:

0%

Estimated time:

Description

Observation

I'm just getting around to updating Fedora's os-autoinst package, which includes the patches from Marek to add ustreamer support. The tests for this are passing on all other arches but failing on s390x, which is currently our only big-endian arch. They fail like this:

2: # Subtest: frame parsing - ustreamer
2: ok 1 - detected invalid data
2: not ok 2 - current screen available to read for JPEG frame
2:
2: # Failed test 'current screen available to read for JPEG frame'
2: # at t/26-video_stream.t line 171.
2: 1..2
2: # Looks like you failed 1 test of 2.
2: not ok 3 - frame parsing - ustreamer

all other subtests pass. The failure indicates that $console->current_screen(); (on line 170) does not give an image at all.

The fact that this is failing on s390x, and I can see the ustreamer code doing stuff like pack("D", $clock); and unpack("QLx4QQIIa4ICCxxI", $ustreamer_map);, makes me suspect very strongly that this is an endianness issue, but I'm not sure I care enough to figure it out myself, not being likely to do anything with ustreamer on s390x in anger. I'll probably just patch this subtest out on s390x, one way or another.

Suggestions

Actions

Also available in: Atom PDF