Actions
action #161393
closedopenQA Project - coordination #112862: [saga][epic] Future ideas for easy multi-machine handling: MM-tests as first-class citizens
openQA Project - coordination #111929: [epic] Stable multi-machine tests covering multiple physical workers
gitlab CI jobs do not execute salt-lint and do not fail on missing "find" executable
Status:
Resolved
Priority:
Normal
Assignee:
-
Category:
Regressions/Crashes
Target version:
Start date:
2024-06-03
Due date:
% Done:
0%
Estimated time:
Description
Observation¶
https://gitlab.suse.de/pdostal/salt-pillars-openqa/-/jobs/2661772#L24
states
$ salt-lint -v $(if command -v git >/dev/null; then git ls-files "*.sls"; else find -name '*.sls'; fi)
/usr/bin/bash: line 149: find: command not found
so does not find "find" but then succeeds because the problem in the command evaluation is ignored so we never call salt-lint
Acceptance criteria¶
- AC1: salt-lint CI jobs succeed again consistently
- AC2: the CI jobs fail if find or another necessary application do not exist
Suggestions¶
- Improve the command to fail if a necessary command does not exist. Possibly we can simplify to just rely on git (or find)
- Ensure that salt-lint CI jobs succeed again consistently
Actions