Project

General

Profile

action #161393

Updated by okurz 7 months ago

## Observation 
 https://gitlab.suse.de/pdostal/salt-pillars-openqa/-/jobs/2661772#L24 
 states 

 ``` 
 $ salt-lint -v $(if command -v git >/dev/null; then git ls-files "*.sls"; else find -name '*.sls'; fi) 
 /usr/bin/bash: line 149: find: command not found 
 ``` 

 so does not find "find" but then succeeds because the problem in the command evaluation is ignored so we never call salt-lint 

 ## Acceptance criteria 
 * **AC1:** salt-lint CI jobs succeed again consistently 
 * **AC2:** the CI jobs fail if find or another necessary application do not exist 

 ## Suggestions 
 * Improve the command to fail if a necessary command does not exist. Possibly we can simplify to just rely on git (or find) git) 
 * Ensure that salt-lint CI jobs succeed again consistently

Back