action #160820
closedopenqa-cli: Do not read from STDIN unless explicitly requested size:S
Description
https://progress.opensuse.org/issues/160820
openqa-cli: Do not read from STDIN unless explicitly requested size:S
Motivation¶
See #160628-9
A shell script called via bash < ...
called openqa-cli, and that was reading STDIN, making it empty, and the rest of the bash script was skipped because bash didn't get any more input lines.
In some cases it might be handy to read from STDIN unrequested, e.g. linters, where it's obvious that they either take a file / dir or STDIN.
But for openqa-cli it was a bit unexpected, and in a context where that data from STDIN wasn't actually used.
It might break things, but still a good idea to add an explicit flag to read from STDIN to prevent confusing implicit behaviour.
Acceptance criteria¶
- AC1: openqa-cli no longer reads from STDIN without a flag being set
Suggestions¶
- Read https://github.com/os-autoinst/openQA/blob/master/script/openqa-cli, in particular
data_from_stdin
in https://github.com/os-autoinst/openQA/blob/master/lib/OpenQA/Command.pm#L33 - Consider adding a command line parameter, e.g.
--non-interactive
, or detect the calling scope or-i -
to explicitly read STDIN and not doing it otherwise - Find out in what cases the client needs to read from STDIN and decide how to call the flag based on that
- Check whether curl has a similar flag and use consistent naming
Updated by tinita 5 months ago
- Copied from action #160628: periodic multi-machine OSD test in https://gitlab.suse.de/openqa/scripts-ci/ does not trigger any jobs size:S added
Updated by tinita about 2 months ago
- Subject changed from openqa-cli: Do not read from STDIN unless explicitly requested to openqa-cli: Do not read from STDIN unless explicitly requested size:S
- Description updated (diff)
- Status changed from New to Workable
Updated by tinita about 2 months ago
- Target version changed from Tools - Next to Ready
Updated by mkittler about 2 months ago
- Status changed from Workable to In Progress
- Assignee set to mkittler
Updated by mkittler about 2 months ago
- Status changed from In Progress to Feedback
Updated by mkittler about 2 months ago
- Status changed from Feedback to Resolved
The PR was merged and I also updated the help text.