Project

General

Profile

Actions

action #160820

closed

openqa-cli: Do not read from STDIN unless explicitly requested size:S

Added by tinita 5 months ago. Updated about 2 months ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
Feature requests
Target version:
Start date:
Due date:
% Done:

0%

Estimated time:

Description

https://progress.opensuse.org/issues/160820

openqa-cli: Do not read from STDIN unless explicitly requested size:S

Motivation

See #160628-9

A shell script called via bash < ... called openqa-cli, and that was reading STDIN, making it empty, and the rest of the bash script was skipped because bash didn't get any more input lines.

In some cases it might be handy to read from STDIN unrequested, e.g. linters, where it's obvious that they either take a file / dir or STDIN.
But for openqa-cli it was a bit unexpected, and in a context where that data from STDIN wasn't actually used.

It might break things, but still a good idea to add an explicit flag to read from STDIN to prevent confusing implicit behaviour.

Acceptance criteria

  • AC1: openqa-cli no longer reads from STDIN without a flag being set

Suggestions


Related issues 1 (0 open1 closed)

Copied from openQA Project - action #160628: periodic multi-machine OSD test in https://gitlab.suse.de/openqa/scripts-ci/ does not trigger any jobs size:SResolvedmkittler2024-01-30

Actions
Actions #1

Updated by tinita 5 months ago

  • Copied from action #160628: periodic multi-machine OSD test in https://gitlab.suse.de/openqa/scripts-ci/ does not trigger any jobs size:S added
Actions #2

Updated by mkittler 5 months ago

  • Target version set to Ready
Actions #3

Updated by okurz 4 months ago

  • Target version changed from Ready to Tools - Next
Actions #4

Updated by okurz 4 months ago

  • Target version changed from Tools - Next to Ready
Actions #5

Updated by okurz 4 months ago

  • Target version changed from Ready to Tools - Next
Actions #6

Updated by tinita about 2 months ago

  • Subject changed from openqa-cli: Do not read from STDIN unless explicitly requested to openqa-cli: Do not read from STDIN unless explicitly requested size:S
  • Description updated (diff)
  • Status changed from New to Workable
Actions #7

Updated by tinita about 2 months ago

  • Target version changed from Tools - Next to Ready
Actions #8

Updated by mkittler about 2 months ago

  • Status changed from Workable to In Progress
  • Assignee set to mkittler
Actions #9

Updated by mkittler about 2 months ago

  • Status changed from In Progress to Feedback
Actions #10

Updated by mkittler about 2 months ago

  • Status changed from Feedback to Resolved

The PR was merged and I also updated the help text.

Actions

Also available in: Atom PDF