Project

General

Profile

Actions
Copy link

action #158236

open

Backlog Limits Checker github workflow fails on pull requests from forks size:S

Added by tinita 30 days ago. Updated about 20 hours ago.

Status:
Workable
Priority:
Urgent
Assignee:
ybonatakis
Category:
Feature requests
Target version:
Ready
Start date:
2024-03-28
Due date:
2024-05-03 (Due in 6 days)
% Done:

0%

Estimated time:
Tags:
reactive work

Description

Observation

https://github.com/openSUSE/backlogger/actions/runs/8468254805/job/23200822772
The workflow is creating a preview of the HTML page in the origin gh-pages branch.
For that, it needs the right permissions. A PR with a branch from origin works, but it fails for forks.

Maybe there are other options to make it work.

Suggestions

  • Research how previews could be done
    • Give permissions to upstream to forks
    • Store the preview elsewhere
    • Lookup other ways to do this in the preview action, or other actions doing this
Actions
Copy link
 #1

Updated by okurz 30 days ago

  • Target version set to Ready
Actions
Copy link
 #2

Updated by okurz 23 days ago

  • Tags set to reactive work
  • Subject changed from Backlog Limits Checker github workflow fails on pull requests on forks to Backlog Limits Checker github workflow fails on pull requests from forks
  • Description updated (diff)
  • Status changed from New to Workable
Actions
Copy link
 #3

Updated by tinita 23 days ago

  • Subject changed from Backlog Limits Checker github workflow fails on pull requests from forks to Backlog Limits Checker github workflow fails on pull requests from forks size:S
Actions
Copy link
 #4

Updated by ybonatakis 22 days ago

  • Status changed from Workable to In Progress
  • Assignee set to ybonatakis
Actions
Copy link
 #5

Updated by ybonatakis 22 days ago

for now i am waiting to get permissions to the https://github.com/openSUSE/backlogger as i cant access the settings

Actions
Copy link
 #6

Updated by livdywan 22 days ago

  • Status changed from In Progress to Workable

Please don't leave it in progress unless you're actively working on it

Actions
Copy link
 #7

Updated by ybonatakis 18 days ago

  • Status changed from Workable to In Progress

access granted. I can open settings on https://github.com/openSUSE/backlogger now.

Actions
Copy link
 #8

Updated by ybonatakis 18 days ago

I added the REDMINE_API_KEY in the forked repo but this didnt work.
I found an open issue which lists some limitation for forked jobs and i commented there, and hope to get some answer/solution https://github.com/rossjrw/pr-preview-action/issues/54

Actions
Copy link
 #9

Updated by openqa_review 17 days ago

  • Due date set to 2024-04-24

Setting due date based on mean cycle time of SUSE QE Tools

Actions
Copy link
 #10

Updated by ybonatakis 17 days ago

  • Due date deleted (2024-04-24)

From the documentation is clear that the workflow doesnt work from forked repos in the current version. There is a PR[0] to fix the issue in the v2 but it is not ready yet.

[0] https://github.com/rossjrw/pr-preview-action/pull/6

Actions
Copy link
 #11

Updated by ybonatakis 17 days ago

  • Status changed from In Progress to Feedback

ybonatakis wrote in #note-8:

I added the REDMINE_API_KEY in the forked repo but this didnt work.
I found an open issue which lists some limitation for forked jobs and i commented there, and hope to get some answer/solution https://github.com/rossjrw/pr-preview-action/issues/54

I got an answer too https://github.com/rossjrw/pr-preview-action/issues/54#issuecomment-2046165272 confirming the state of the project. there is a workaround tho which comes with some security caveats.

Change it to feedback for further discussion

Actions
Copy link
 #12

Updated by livdywan 17 days ago

Discussed in the unblock:

Actions
Copy link
 #13

Updated by ybonatakis 17 days ago

  • Status changed from Feedback to In Progress
Actions
Copy link
 #15

Updated by openqa_review 16 days ago

  • Due date set to 2024-04-25

Setting due date based on mean cycle time of SUSE QE Tools

Actions
Copy link
 #16

Updated by ybonatakis 11 days ago

  • Status changed from In Progress to Feedback

waiting for @titina

Actions
Copy link
 #17

Updated by ybonatakis 5 days ago

  • Status changed from Feedback to In Progress

reopen due to the comment in the PR[0].

the testing commit is checked out but then Run the action implemented in this repo runs another checkout.

[0] https://github.com/openSUSE/backlogger/pull/38#issuecomment-2064171707

Actions
Copy link
 #18

Updated by ybonatakis 5 days ago

  • Status changed from In Progress to Feedback
Actions
Copy link
 #19

Updated by ybonatakis 3 days ago ยท Edited

addressing the comment[0] from @tinita i encountered an unrelated issue with the container. the previews actions looks good tho with the correct commit hash

[0] https://github.com/openSUSE/backlogger/pull/42#discussion_r1575344367

Actions
Copy link
 #21

Updated by livdywan 1 day ago

  • Due date changed from 2024-04-25 to 2024-05-03

ybonatakis wrote in #note-20:

i think it works https://github.com/openSUSE/backlogger/actions/runs/8815937064/job/24220533045
but i cant tell for sure how it will affect https://github.com/os-autoinst/qa-tools-backlog-assistant/blob/master/.github/workflows/backlog_checker.yml#L21

Is this the correct link? That's a PR on the upstream repo. We need the preview to work on forks.

Actions
Copy link
 #22

Updated by okurz 1 day ago

  • Status changed from Feedback to In Progress
  • Priority changed from Normal to Urgent

To actually address that we missed the planned due date we should bump prio as decided in the daily now.

Actions
Copy link
 #23

Updated by livdywan about 20 hours ago

  • Status changed from In Progress to Workable

Let's discuss this on Monday. Pulling a ticket in progress without confirming someone can work on it is not enough to get it done. If someone did work on, or further discuss this, please do add your comments here of course.

Actions
Copy link

Also available in: Atom PDF