Project

General

Profile

Actions

action #153805

open

coordination #96596: [qe-core][CI] CI/CD and Coding style improvements

[qe-core] Implement checks so that tests that don't use assert_screen, use use serial console instead

Added by szarate 10 months ago. Updated 6 months ago.

Status:
In Progress
Priority:
Normal
Assignee:
Category:
Refactor/Code Improvements
Target version:
Start date:
2024-01-17
Due date:
% Done:

0%

Estimated time:
Difficulty:
Sprint:
QE-Core: May Sprint 24 (May 07 - Jun 04)

Description

Since we're deprioritizing screen-based testing, something that has bothered me for quite a while is that we often have test modules that are console-only (i.e no ncurses) and could be better handled with a serial console, but they use root console or others. So we'd like to prevent test developers from creating new tests, which such bad practice

In reality what we want to achieve is to Prevent openQA from relying on VNC, as assert_screen needs a tty (either console or x11/wayland)

Particularly relevant for tests with consolebasetest in their parent hierarchy.

Acceptance criteria:

  • The RFC request was added to CONTRIBUTING.md with the new rule.
  • Pull Request is merged
  • A format is considered to allow or skip the rule check purposefully
Actions #1

Updated by szarate 10 months ago

  • Tracker changed from coordination to action
Actions #2

Updated by szarate 10 months ago

  • Sprint changed from QE-Core: December Sprint 23 (Dec 13 - Jan 10) to QE-Core: February Sprint 24 (Jan 31 - Feb 28)
Actions #3

Updated by szarate 10 months ago

  • Description updated (diff)
Actions #4

Updated by szarate 10 months ago

The security team might need screenshots as part of evidence of what they do, so it's a "in most cases" rather than in all cases.

Possibly there could be a child class of opensusebasetest or flag that could alter the behavior of the checker.

Actions #5

Updated by cvidot 9 months ago

  • Status changed from Workable to In Progress
  • Assignee set to cvidot
Actions #6

Updated by mgrifalconi 9 months ago

  • Sprint changed from QE-Core: February Sprint 24 (Jan 31 - Feb 28) to QE-Core: March Sprint 24 (Mar 06 - Mar 28)
Actions #7

Updated by szarate 8 months ago

  • Sprint changed from QE-Core: March Sprint 24 (Mar 06 - Mar 28) to QE-Core: April Sprint 24 (Apr 10 - May 08)
Actions #9

Updated by szarate 6 months ago

  • Sprint changed from QE-Core: April Sprint 24 (Apr 10 - May 08) to QE-Core: May Sprint 25 (May 07 - Jun 04)
Actions

Also available in: Atom PDF