action #153340
closedOBS CI checks for os-autoinst subpackages size:M
Description
Motivation¶
https://github.com/os-autoinst/os-autoinst/pull/2430#discussion_r1447407616
os-autoinst OBS CI checks only check the main package, not the openvswitch subpackage unlike openQA (see e.g. OBS checks in os-autoinst/openQA#5352) showing OBS: openQA:openQA-client-test and OBS: openQA:openQA-test and such.
Acceptance criteria¶
- AC1: os-autoinst pull requests trigger OBS CI checks for each os-autoinst subpackage
Suggestions¶
- Lookup how it's done in openQA and do the same for os-autoinst https://github.com/os-autoinst/os-autoinst/blob/master/.obs/workflows.yml
- look into the .obs folder within the git repos
- Maybe it is as simple as copying https://github.com/os-autoinst/os-autoinst/blob/master/dist/rpm/os-autoinst-test.spec into the corresponding sub-package specific variant, compare to https://github.com/os-autoinst/openQA/tree/master/dist/rpm
- For a specific runtime test see e.g. https://github.com/os-autoinst/openQA/blob/master/dist/rpm/openQA-client-test.spec#L19
- OBS might behave different wrt how it's preparing its chroot - use TDD and add something to try if it would fail on OBS, like an explicitly broken line
Updated by jbaier_cz 4 months ago
- Status changed from Workable to Feedback
With https://github.com/os-autoinst/os-autoinst/pull/2439 already merged, I added the newly created spec file into service file for os-autoinst and also added them into multibuild configuration. Now we need to wait for build.
Updated by jbaier_cz 4 months ago
- Related to action #153544: os-autoinst:os-autoinst-openvswitch-test not building on Leap_15.5 x86_64 added
Updated by jbaier_cz 4 months ago
The test sub-package is pulling latest successful version of the package, which can yield unexpected results (like successful build test for package which cannot be build at all). https://github.com/os-autoinst/os-autoinst/pull/2441 should fix that.
Updated by livdywan 4 months ago
- Status changed from In Progress to Feedback
jbaier_cz wrote in #note-6:
The test sub-package is pulling latest successful version of the package, which can yield unexpected results (like successful build test for package which cannot be build at all). https://github.com/os-autoinst/os-autoinst/pull/2441 should fix that.
The branch got merged.
For some reason this is commented out in
https://github.com/os-autoinst/os-autoinst/blob/master/dist/rpm/os-autoinst-test.spec#L8
Is this q from the PR still relevant?
Updated by jbaier_cz 4 months ago
livdywan wrote in #note-7:
For some reason this is commented out in
https://github.com/os-autoinst/os-autoinst/blob/master/dist/rpm/os-autoinst-test.spec#L8Is this q from the PR still relevant?
Yeah, I was also interested about the reason. The git blame suggested it was like this forever, so the question might not be that important.