action #152681
closedcoordination #58184: [saga][epic][use case] full version control awareness within openQA
coordination #152847: [epic] version control awareness within openQA for test distributions
openqa-investigate creates wrong CASEDIR setting for some tests size:M
0%
Description
Observation¶
https://openqa.opensuse.org/tests/3815334#comments has:
openqa_from_bootstrap:investigate:retry: https://openqa.opensuse.org/tests/3815345
openqa_from_bootstrap:investigate:last_good_tests:92866dcb2f14046a8e26a47bcb0f0ee3959920b3: https://openqa.opensuse.org/tests/3815346
openqa_from_bootstrap:investigate:last_good_build::TW.25094: https://openqa.opensuse.org/tests/3815347
openqa_from_bootstrap:investigate:last_good_tests_and_build:92866dcb2f14046a8e26a47bcb0f0ee3959920b3+:TW.25094: https://openqa.opensuse.org/tests/3815348
The last_good_tests and last_good_tests_and_build are both failing because they have:
CASEDIR https://github.com/os-autoinst/os-autoinst-distri-opensuse.git#92866dcb2f14046a8e26a47bcb0f0ee3959920b3
But it should be os-autoinst-distri-openqa instead, and the commit 92866dcb2f14046a8e26a47bcb0f0ee3959920b3 is not found.
That's because:
https://github.com/os-autoinst/scripts/blob/master/openqa-investigate#L56
repo=${casedir:-'https://github.com/os-autoinst/os-autoinst-distri-opensuse.git'}
Acceptance Criteria¶
- AC1: openQA-in-openQA investigation jobs show correct "last_good_tests" jobs using test code from os-autoinst-distri-openQA (not os-autoinst-distri-opensuse)
Suggestions¶
Confirm that no information is lost if CASEDIR is overwritten- git ref is still available
- branch name is still known
- users are not typically confused
- Try to solve it with a simple hacky solution and think about consequences later, i.e. add more ideas to the parent epic :)
In os-autoinst we already compute the TEST_GIT_HASH so probably it's easy to look up the actual git repo used if any and then overwrite CASEDIR after isotovideo read casedirThen confirm that openqa-investigate can read the updated CASEDIRIf it turns out that CASEDIR can not or should not be overwritten then we could introduce a new TEST_GIT/NEEDLES_GIT variableTEST_GIT_URL/NEEDLES_GIT_URL
was added
Updated by tinita 12 months ago
CASEDIR
is rewritten already during the cloning phase, as well as NEEDLES_DIR
:
https://github.com/os-autoinst/os-autoinst/blob/master/OpenQA/Isotovideo/Utils.pm#L123
So first it might be a url, then it gets rewritten to the local checkout path. I don't think it's a good idea to change it later again.
Also, isotovideo needs it to be a path to locate test code.
Updated by tinita 12 months ago
https://github.com/os-autoinst/os-autoinst/pull/2423 Add TEST_GIT_URL/NEEDLES_GIT_URL to vars
Updated by tinita 12 months ago ยท Edited
https://github.com/os-autoinst/os-autoinst/pull/2423 merged, so now openqa-investigate can take this information for setting CASEDIR repo
Updated by ybonatakis 11 months ago
- Status changed from Workable to In Progress
- Assignee set to ybonatakis
Updated by openqa_review 11 months ago
- Due date set to 2024-01-27
Setting due date based on mean cycle time of SUSE QE Tools
Updated by ybonatakis 11 months ago
- Due date deleted (
2024-01-27) - Status changed from In Progress to Feedback
https://github.com/os-autoinst/scripts/pull/278
Simply override $casedir
when $testgiturl
is set.
Updated by ybonatakis 11 months ago
- Status changed from In Progress to Feedback
So I editted the commit. Main change is fetching the TEST_GIT_URL from vars.json.
VR: https://openqa.opensuse.org/tests/3875380#settings
Updated by okurz 11 months ago
- Status changed from Feedback to Resolved
https://github.com/os-autoinst/scripts/pull/278 merged. That looks quite good. I trust that in production that works the same as we already have verifications using openqa.opensuse.org