Project

General

Profile

Actions

action #152681

closed

coordination #58184: [saga][epic][use case] full version control awareness within openQA

coordination #152847: [epic] version control awareness within openQA for test distributions

openqa-investigate creates wrong CASEDIR setting for some tests size:M

Added by tinita 4 months ago. Updated 3 months ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
Feature requests
Target version:
Start date:
2023-12-15
Due date:
% Done:

0%

Estimated time:

Description

Observation

https://openqa.opensuse.org/tests/3815334#comments has:

openqa_from_bootstrap:investigate:retry: https://openqa.opensuse.org/tests/3815345
openqa_from_bootstrap:investigate:last_good_tests:92866dcb2f14046a8e26a47bcb0f0ee3959920b3: https://openqa.opensuse.org/tests/3815346
openqa_from_bootstrap:investigate:last_good_build::TW.25094: https://openqa.opensuse.org/tests/3815347
openqa_from_bootstrap:investigate:last_good_tests_and_build:92866dcb2f14046a8e26a47bcb0f0ee3959920b3+:TW.25094: https://openqa.opensuse.org/tests/3815348

The last_good_tests and last_good_tests_and_build are both failing because they have:
CASEDIR https://github.com/os-autoinst/os-autoinst-distri-opensuse.git#92866dcb2f14046a8e26a47bcb0f0ee3959920b3

But it should be os-autoinst-distri-openqa instead, and the commit 92866dcb2f14046a8e26a47bcb0f0ee3959920b3 is not found.

That's because:
https://github.com/os-autoinst/scripts/blob/master/openqa-investigate#L56

        repo=${casedir:-'https://github.com/os-autoinst/os-autoinst-distri-opensuse.git'}

Acceptance Criteria

  • AC1: openQA-in-openQA investigation jobs show correct "last_good_tests" jobs using test code from os-autoinst-distri-openQA (not os-autoinst-distri-opensuse)

Suggestions

  • Confirm that no information is lost if CASEDIR is overwritten
    • git ref is still available
    • branch name is still known
    • users are not typically confused
  • Try to solve it with a simple hacky solution and think about consequences later, i.e. add more ideas to the parent epic :)
  • In os-autoinst we already compute the TEST_GIT_HASH so probably it's easy to look up the actual git repo used if any and then overwrite CASEDIR after isotovideo read casedir
  • Then confirm that openqa-investigate can read the updated CASEDIR
  • If it turns out that CASEDIR can not or should not be overwritten then we could introduce a new TEST_GIT/NEEDLES_GIT variable TEST_GIT_URL/NEEDLES_GIT_URL was added
Actions #1

Updated by tinita 4 months ago

  • Description updated (diff)
Actions #2

Updated by okurz 4 months ago

  • Tags set to reactive work
  • Category set to Feature requests
  • Target version set to Ready
Actions #3

Updated by tinita 4 months ago

  • Subject changed from openqa-investigate creates wrong CASEDIR setting for some tests to openqa-investigate creates wrong CASEDIR setting for some tests size:M
  • Description updated (diff)
  • Status changed from New to Workable
  • Parent task set to #152847
Actions #4

Updated by tinita 4 months ago

CASEDIR is rewritten already during the cloning phase, as well as NEEDLES_DIR:
https://github.com/os-autoinst/os-autoinst/blob/master/OpenQA/Isotovideo/Utils.pm#L123
So first it might be a url, then it gets rewritten to the local checkout path. I don't think it's a good idea to change it later again.
Also, isotovideo needs it to be a path to locate test code.

Actions #5

Updated by tinita 4 months ago

https://github.com/os-autoinst/os-autoinst/pull/2423 Add TEST_GIT_URL/NEEDLES_GIT_URL to vars

Actions #6

Updated by tinita 4 months ago ยท Edited

https://github.com/os-autoinst/os-autoinst/pull/2423 merged, so now openqa-investigate can take this information for setting CASEDIR repo

Actions #7

Updated by tinita 3 months ago

  • Description updated (diff)
Actions #8

Updated by ybonatakis 3 months ago

  • Status changed from Workable to In Progress
  • Assignee set to ybonatakis
Actions #9

Updated by openqa_review 3 months ago

  • Due date set to 2024-01-27

Setting due date based on mean cycle time of SUSE QE Tools

Actions #10

Updated by ybonatakis 3 months ago

  • Due date deleted (2024-01-27)
  • Status changed from In Progress to Feedback

https://github.com/os-autoinst/scripts/pull/278
Simply override $casedir when $testgiturl is set.

Actions #11

Updated by okurz 3 months ago

  • Status changed from Feedback to In Progress
Actions #12

Updated by livdywan 3 months ago

As discussed in the daily, please check that cloning the job works on o3, and clarify that the GIT_URL works even via job settings, or wether that needs an additional fix

Actions #13

Updated by ybonatakis 3 months ago

  • Status changed from In Progress to Feedback

So I editted the commit. Main change is fetching the TEST_GIT_URL from vars.json.
VR: https://openqa.opensuse.org/tests/3875380#settings

Actions #14

Updated by okurz 3 months ago

  • Status changed from Feedback to Resolved

https://github.com/os-autoinst/scripts/pull/278 merged. That looks quite good. I trust that in production that works the same as we already have verifications using openqa.opensuse.org

Actions

Also available in: Atom PDF