Project

General

Profile

Actions

action #137195

closed

Test fails in bootcode_options due to changed widget IDs

Added by dimstar 8 months ago. Updated 8 months ago.

Status:
Resolved
Priority:
High
Assignee:
Target version:
Start date:
2023-09-28
Due date:
% Done:

0%

Estimated time:

Description

Observation

Seems to be one more case where the yastbootloader change hits us:

Not Found
{ "error" : "Widget not found" }

The widget tree was slightly changed in yast2-bootloader 5.x to accommodate more bootloaders than just grub2

openQA test in scenario opensuse-Tumbleweed-DVD-x86_64-yast2_gui@64bit fails in
bootcode_options

Additional information

The problem is caused by renaming the widget IDs in grub2_widgets_test.rb in this PR

This still affects our tests that rely on the old Widget Ids.

Affected IDs are:

lib/YaST/Bootloader/BootCodeOptionsPage.pm:    $self->{chb_set_active_flag} = $self->{app}->checkbox({id => '"Bootloader::ActivateWidget"'});
lib/YaST/Bootloader/BootCodeOptionsPage.pm:    $self->{chb_generic_to_mbr} = $self->{app}->checkbox({id => '"Bootloader::GenericMBRWidget"'});
lib/YaST/Bootloader/BootCodeOptionsPage.pm:    $self->{cmb_mbr_flag} = $self->{app}->combobox({id => '"Bootloader::PMBRWidget"'});
lib/YaST/Bootloader/BootCodeOptionsPage.pm:    $self->{chb_trusted_boot} = $self->{app}->checkbox({id => '"Bootloader::TrustedBootWidget"'});

lib/YaST/Bootloader/KernelParametersPage.pm:    $self->{txb_opt_kernel_param} = $self->{app}->textbox({id => "\"Bootloader::KernelAppendWidget\""});

ToDo

Replace the old IDs that won't work in newer YaST versions with a regex that matches both the old or new version. You can take PR 17878 as an example.

Acceptance criteria:

AC1: Changed IDs that affect our code are replaced by regex code that matches both new and old IDs.

Actions

Also available in: Atom PDF