action #137195
closedTest fails in bootcode_options due to changed widget IDs
Description
Observation¶
Seems to be one more case where the yastbootloader change hits us:
Not Found
{ "error" : "Widget not found" }
The widget tree was slightly changed in yast2-bootloader 5.x to accommodate more bootloaders than just grub2
openQA test in scenario opensuse-Tumbleweed-DVD-x86_64-yast2_gui@64bit fails in
bootcode_options
Additional information¶
The problem is caused by renaming the widget IDs in grub2_widgets_test.rb
in this PR
This still affects our tests that rely on the old Widget Ids.
Affected IDs are:
lib/YaST/Bootloader/BootCodeOptionsPage.pm: $self->{chb_set_active_flag} = $self->{app}->checkbox({id => '"Bootloader::ActivateWidget"'});
lib/YaST/Bootloader/BootCodeOptionsPage.pm: $self->{chb_generic_to_mbr} = $self->{app}->checkbox({id => '"Bootloader::GenericMBRWidget"'});
lib/YaST/Bootloader/BootCodeOptionsPage.pm: $self->{cmb_mbr_flag} = $self->{app}->combobox({id => '"Bootloader::PMBRWidget"'});
lib/YaST/Bootloader/BootCodeOptionsPage.pm: $self->{chb_trusted_boot} = $self->{app}->checkbox({id => '"Bootloader::TrustedBootWidget"'});
lib/YaST/Bootloader/KernelParametersPage.pm: $self->{txb_opt_kernel_param} = $self->{app}->textbox({id => "\"Bootloader::KernelAppendWidget\""});
ToDo¶
Replace the old IDs that won't work in newer YaST versions with a regex that matches both the old or new version. You can take PR 17878 as an example.
Acceptance criteria:¶
AC1: Changed IDs that affect our code are replaced by regex code that matches both new and old IDs.
Updated by dimstar about 1 year ago
That comes down to
$self->{chb_set_active_flag} = $self->{app}->checkbox({id => '"Bootloader::ActivateWidget"'});
in yast20bootloader 5.0.1, this was changed to
Bootloader::Grub2Widget::ActivateWidget
And there are some more, like:
Bootloader::GenericMBRWidget => Bootloader::Grub2Widget::GenericMBRWidget
Bootloader::TrustedBootWidget => Bootloader::Grub2Widget::TrustedBootWidget
Bootloader::PMBRWidget => describe Bootloader::Grub2Widget::PMBRWidget
Updated by dimstar about 1 year ago
@rainerkoenig is this something you can fix the same way using regex?
Updated by rainerkoenig about 1 year ago
- Project changed from openQA Tests (public) to qe-yam
- Subject changed from test fails in bootcode_options to Test fails in bootcode_options due to changed widget IDs
- Category deleted (
Bugs in existing tests) - Status changed from New to Workable
- Priority changed from Normal to High
- Target version set to Current
Yes, same issue. Currently checking all renamed widgets, we also have hits in
lib/YaST/Bootloader/KernelParametersPage.pm: $self->{txb_opt_kernel_param} = $self->{app}->textbox({id => "\"Bootloader::KernelAppendWidget\""});
I hijack this for our yam project and increase the priority.
Updated by lmanfredi about 1 year ago
- Status changed from Workable to In Progress
- Assignee set to lmanfredi