Project

General

Profile

Actions
Copy link

action #1348

closed

action #1347: Cleanup plugins

Investigate what is in what plugin already

Added by _miska_ about 10 years ago. Updated about 10 years ago.

Status:
Closed
Priority:
Normal
Assignee:
_miska_
Target version:
Staging sprint 1
Start date:
2014-02-06
Due date:
% Done:

100%

Estimated time:
(Total: 20.00 h)

Description

Figure out what do we have where and where it belongs

Subtasks 1 (0 open — 1 closed)

action #1419: Migrate rqlink from separate script into staging pluginClosed_miska_2014-02-06

Actions

Related issues 1 (0 open — 1 closed)

Blocks Staging project workflow - action #1287: Add status checker for staging projectsResolved_miska_2014-01-28

Actions
Actions
Copy link
 #1

Updated by _miska_ about 10 years ago

  • % Done changed from 0 to 70

My findings so far:

  • staging script has working checks for dirty and building, creation needs to be redone
  • check_core plugin looks like creation part with few bits and pieces missing
    • we will probably throw away/rewrite check_core once we have a proper API
    • probably should be merged into staging plugin and polished
  • checkcore.pl looks like something to maintain the rings, doesn't do changes directly, might be a good GSoC for Alberto to play with graphs
  • osc-group has plenty of usefull functions for searching for various SRs which will be usefull in future, but grouping will be redone anyway
  • osc-rqlink is just a helper, functionality already in osc-staging, we can drop that one
  • queue-all.sh and generate-reminder.pl generates factory reminder mails
  • sync-rebuild.py triggers rebuild for whatever is building only in one of openSUSE:Factory{,:Rebuild}
  • osc-check_repo.py looks like something that tries to detect cycles in rq
  • osc-check_source.py & source-checker.pl looks like part of automatic QA
Actions
Copy link
 #2

Updated by coolo about 10 years ago

Unfortunately a lot of this is incorrect. I already merged check_core and one part of checkcore.pl into the staging plugin and it would be good to merge rqlink too. Staging does not offer rqlink's functionality at the moment.

Actions
Copy link
 #3

Updated by _miska_ about 10 years ago

As far as I understood rqlink just takes a request and does a symlink with correct version/revision which is/was how I created staging projects.

But yeah, I haven't checked how staging plugin changed :-)

Actions
Copy link
 #4

Updated by coolo about 10 years ago

creating projects is a slightly different task than creating links though :)

Actions
Copy link
 #5

Updated by _miska_ about 10 years ago

Ok, looks like quite some stuff is in staging plugin already, some stuff has similar functionality, looks like what is missing is cleanup of staging plugin, merge the functions that do similar stuff generalize and document stuff.

Actions
Copy link
 #6

Updated by coolo about 10 years ago

Yes, once we have a test suite we can refactor.

Actions
Copy link
 #7

Updated by _miska_ about 10 years ago

  • Status changed from New to Closed

Not worth investigating more now, we will revisit once we are done/almost done to verify we haven't forgot something important, will create a task for that.

Actions
Copy link

Also available in: Atom PDF