Project

General

Profile

Actions

action #127529

closed

coordination #121825: [epic] Enabling and enhacements for products in maintenance

Implement java popup handling inside the installation libraries

Added by syrianidou_sofia about 1 year ago. Updated 11 months ago.

Status:
Resolved
Priority:
Urgent
Target version:
Start date:
2023-04-12
Due date:
% Done:

0%

Estimated time:

Description

Motivation

After failures cause by Java license popup we implemented a solution, added directly in confirm_installation.pm. To make the solution more practical and possibly use it in further distributions, it should be moved into our framework to avoid conditional logic on Test Layer.

Furthermore, the Java License popup, appears during installation only when there are maintenance updates for the particular package, so the same tests for some maintenance update releases will have the popup and for some, not. The solution should not cause test failure when the Java license popup does not appear. There should be a condition inside the Installation library function confirm_installation() that will check if the popup appears, in this case accept it and record_info. If it does not appear, then proceed to confirm installation as it currently does.

Acceptance criteria

AC1: The confirm_installation.pm will only run the function confirm_installation() as it was previously, but now it will accept as argument list of SCC_ADDONS
AC2: There will be an specific implementation of this method for SLE 15 SP4 via distribution pattern, so we can avoid the part of condition related with the product
AC3: We have an explicit wait in confirm_installation that most likely could be removed, because the Java popup appears almost instantaneously. We need to try to remove it or, in case it's not possible, to minimize the wait time.

Additional information

Previous work: https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/16830

Actions #1

Updated by syrianidou_sofia about 1 year ago

  • Target version set to Current
Actions #2

Updated by syrianidou_sofia about 1 year ago

  • Description updated (diff)
Actions #3

Updated by syrianidou_sofia about 1 year ago

  • Description updated (diff)
Actions #4

Updated by syrianidou_sofia about 1 year ago

  • Description updated (diff)
Actions #5

Updated by JERiveraMoya about 1 year ago

  • Description updated (diff)
  • Status changed from New to Workable
  • Parent task set to #121876
Actions #6

Updated by syrianidou_sofia about 1 year ago

  • Description updated (diff)
Actions #7

Updated by syrianidou_sofia about 1 year ago

Removed the temporary solution due to absence of java licence popup
https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/16876/files

Actions #8

Updated by syrianidou_sofia about 1 year ago

  • Priority changed from Normal to High
Actions #9

Updated by syrianidou_sofia about 1 year ago

  • Description updated (diff)
Actions #10

Updated by syrianidou_sofia about 1 year ago

  • Status changed from Workable to In Progress
  • Assignee set to syrianidou_sofia
Actions #11

Updated by JERiveraMoya about 1 year ago

  • Priority changed from High to Low
Actions #13

Updated by JERiveraMoya 12 months ago

  • Parent task changed from #121876 to #121825
Actions #14

Updated by syrianidou_sofia 11 months ago

  • Priority changed from Low to Urgent
Actions #15

Updated by syrianidou_sofia 11 months ago

We faced this failure again and it was a good opportunity to test the code. All VRs pass: SP5 -> https://openqa.suse.de/tests/overview?version=15-SP5&build=sofiasyria%2Fos-autoinst-distri-opensuse%23java_popup&distri=sle
SP4 -> https://openqa.suse.de/tests/overview?distri=sle&build=sofiasyria%2Fos-autoinst-distri-opensuse%23java_popup&version=15-SP4

Progress ticket for exploring race conditions: https://progress.opensuse.org/issues/132839

And there will be a PR fro renaming get_ok_popup_controller and get_yes_no_popup_controller in order to remove the _controller part from the function.
experimental: https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/17428/files

Actions #16

Updated by syrianidou_sofia 11 months ago

  • Status changed from In Progress to Resolved

Production runs pass

Actions

Also available in: Atom PDF