Project

General

Profile

action #124484

Flaky coverage in lib/openQA/Worker/Job.pm

Added by okurz 3 months ago. Updated 3 months ago.

Status:
Resolved
Priority:
Normal
Assignee:
kraih
Category:
Concrete Bugs
Target version:
Ready
Start date:
2023-02-14
Due date:
% Done:

0%

Estimated time:
Difficulty:
Tags:
reactive work

Description

Motivation

See https://github.com/os-autoinst/openQA/pull/4997#issuecomment-1428080611

Acceptance criteria

  • AC1: Test coverage in lib/openQA/Worker/Job.pm is not flaky anymore

History

#1 Updated by kraih 3 months ago

  • Assignee set to kraih

#2 Updated by kraih 3 months ago

  • Status changed from New to In Progress

#3 Updated by openqa_review 3 months ago

  • Due date set to 2023-03-07

Setting due date based on mean cycle time of SUSE QE Tools

#4 Updated by kraih 3 months ago

  • Description updated (diff)

#5 Updated by kraih 3 months ago

The flaky code block appears to be covered by this test block in t/33-developer_mode.t. One of the tests suggests that it is intended to be flaky:

    ok wait_for_result_panel($driver, qr/(State: cancelled|Result: (user_cancelled|passed))/),
      'test 1 has been cancelled (if it was fast enough to actually pass that is ok, too)';

#6 Updated by kraih 3 months ago

This is the commit that started allowing both user_cancelled and passed to be acceptable test results. It's an intentional race condition.

#7 Updated by kraih 3 months ago

PR marking the block in question as uncoverable: https://github.com/os-autoinst/openQA/pull/5023

#8 Updated by kraih 3 months ago

  • Status changed from In Progress to Feedback

#9 Updated by kraih 3 months ago

Merged.

#10 Updated by okurz 3 months ago

  • Due date deleted (2023-03-07)
  • Status changed from Feedback to Resolved

Resolved as the change is very specific and we trust it and if code coverage would still be flaky we would notice ourselves immediately.

Also available in: Atom PDF