Actions
action #124484
closedFlaky coverage in lib/openQA/Worker/Job.pm
Start date:
2023-02-14
Due date:
% Done:
0%
Estimated time:
Tags:
Description
Motivation¶
See https://github.com/os-autoinst/openQA/pull/4997#issuecomment-1428080611
Acceptance criteria¶
- AC1: Test coverage in
lib/openQA/Worker/Job.pm
is not flaky anymore
Updated by openqa_review over 1 year ago
- Due date set to 2023-03-07
Setting due date based on mean cycle time of SUSE QE Tools
Updated by kraih over 1 year ago
The flaky code block appears to be covered by this test block in t/33-developer_mode.t
. One of the tests suggests that it is intended to be flaky:
ok wait_for_result_panel($driver, qr/(State: cancelled|Result: (user_cancelled|passed))/),
'test 1 has been cancelled (if it was fast enough to actually pass that is ok, too)';
Updated by kraih over 1 year ago
This is the commit that started allowing both user_cancelled
and passed
to be acceptable test results. It's an intentional race condition.
Updated by kraih over 1 year ago
PR marking the block in question as uncoverable: https://github.com/os-autoinst/openQA/pull/5023
Updated by okurz over 1 year ago
- Due date deleted (
2023-03-07) - Status changed from Feedback to Resolved
Resolved as the change is very specific and we trust it and if code coverage would still be flaky we would notice ourselves immediately.
Actions