https://progress.opensuse.org/https://progress.opensuse.org/themes/openSUSE/favicon/favicon.ico?15829177842023-02-17T10:36:15ZopenSUSE Project Management ToolopenQA Project - action #124484: Flaky coverage in lib/openQA/Worker/Job.pmhttps://progress.opensuse.org/issues/124484?journal_id=6035302023-02-17T10:36:15Zkraihsebastian.riedel@suse.com
<ul><li><strong>Assignee</strong> set to <i>kraih</i></li></ul> openQA Project - action #124484: Flaky coverage in lib/openQA/Worker/Job.pmhttps://progress.opensuse.org/issues/124484?journal_id=6041902023-02-20T10:28:04Zkraihsebastian.riedel@suse.com
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>In Progress</i></li></ul> openQA Project - action #124484: Flaky coverage in lib/openQA/Worker/Job.pmhttps://progress.opensuse.org/issues/124484?journal_id=6044602023-02-21T04:11:25Zopenqa_reviewopenqa-review@suse.de
<ul><li><strong>Due date</strong> set to <i>2023-03-07</i></li></ul><p>Setting due date based on mean cycle time of SUSE QE Tools</p>
openQA Project - action #124484: Flaky coverage in lib/openQA/Worker/Job.pmhttps://progress.opensuse.org/issues/124484?journal_id=6063712023-02-24T15:21:00Zkraihsebastian.riedel@suse.com
<ul><li><strong>Description</strong> updated (<a title="View differences" href="/journals/606371/diff?detail_id=569135">diff</a>)</li></ul> openQA Project - action #124484: Flaky coverage in lib/openQA/Worker/Job.pmhttps://progress.opensuse.org/issues/124484?journal_id=6063832023-02-24T16:05:21Zkraihsebastian.riedel@suse.com
<ul></ul><p>The flaky code block appears to be covered by <a href="https://github.com/os-autoinst/openQA/blob/aee8d8cbca6d0698ea02d6bcbe72a774e1a410bc/t/33-developer_mode.t#L337" class="external">this test block</a> in <code>t/33-developer_mode.t</code>. One of the tests suggests that it is intended to be flaky:</p>
<pre><code> ok wait_for_result_panel($driver, qr/(State: cancelled|Result: (user_cancelled|passed))/),
'test 1 has been cancelled (if it was fast enough to actually pass that is ok, too)';
</code></pre> openQA Project - action #124484: Flaky coverage in lib/openQA/Worker/Job.pmhttps://progress.opensuse.org/issues/124484?journal_id=6063862023-02-24T16:20:39Zkraihsebastian.riedel@suse.com
<ul></ul><p><a href="https://github.com/os-autoinst/openQA/commit/ae79e36c7c1c663eafe4a493b8765c322754bbc5" class="external">This</a> is the commit that started allowing both <code>user_cancelled</code> and <code>passed</code> to be acceptable test results. It's an intentional race condition.</p>
openQA Project - action #124484: Flaky coverage in lib/openQA/Worker/Job.pmhttps://progress.opensuse.org/issues/124484?journal_id=6063892023-02-24T16:51:34Zkraihsebastian.riedel@suse.com
<ul></ul><p>PR marking the block in question as uncoverable: <a href="https://github.com/os-autoinst/openQA/pull/5023" class="external">https://github.com/os-autoinst/openQA/pull/5023</a></p>
openQA Project - action #124484: Flaky coverage in lib/openQA/Worker/Job.pmhttps://progress.opensuse.org/issues/124484?journal_id=6066082023-02-27T10:50:02Zkraihsebastian.riedel@suse.com
<ul><li><strong>Status</strong> changed from <i>In Progress</i> to <i>Feedback</i></li></ul> openQA Project - action #124484: Flaky coverage in lib/openQA/Worker/Job.pmhttps://progress.opensuse.org/issues/124484?journal_id=6066112023-02-27T10:50:12Zkraihsebastian.riedel@suse.com
<ul></ul><p>Merged.</p>
openQA Project - action #124484: Flaky coverage in lib/openQA/Worker/Job.pmhttps://progress.opensuse.org/issues/124484?journal_id=6076072023-03-01T10:35:52Zokurzokurz@suse.com
<ul><li><strong>Due date</strong> deleted (<del><i>2023-03-07</i></del>)</li><li><strong>Status</strong> changed from <i>Feedback</i> to <i>Resolved</i></li></ul><p>Resolved as the change is very specific and we trust it <em>and</em> if code coverage would still be flaky we would notice ourselves immediately.</p>