QA (public) » openQA Project (public)

Wicked solves it with the following code in the spec file:

%if %{with systemd}

%pre service
# upgrade from sysconfig[-network] scripts
_id=`readlink /etc/systemd/system/network.service 2>/dev/null` || :
if test "x${_id##*/}" = "xnetwork.service" -a -x /etc/init.d/network ; then
    /etc/init.d/network stop-all-dhcp-clients || :
fi
%{service_add_pre wicked.service}

%post service
%{service_add_post wicked.service}
# See bnc#843526: presets do not apply for upgrade / are not sufficient
#                 to handle sysconfig-network|wicked -> wicked migration
_id=`readlink /etc/systemd/system/network.service 2>/dev/null` || :
case "${_id##*/}" in
""|wicked.service|network.service)
    /usr/bin/systemctl --system daemon-reload || :
    /usr/bin/systemctl --force enable wicked.service || :
;;
esac

%preun service
# stop the daemons on removal
# - stopping wickedd should be sufficient ... other just to be sure.
# - stopping of the wicked.service does not stop network, but removes
#   the wicked.service --> network.service link and resets its status.
%{service_del_preun wickedd.service wickedd-auto4.service wickedd-dhcp4.service wickedd-dhcp6.service wickedd-nanny.service wicked.service}

%postun service
# restart wickedd after upgrade
%{service_del_postun wickedd.service}
…
%endif

however NetworkManager and also systemd-network do not provide that when I tried out the install in a container environment. I guess one should still research about a systemd ecosystem best practice here.

I think we can do the transition in to phases:

1. Move from openqa-worker@.service to openqa-worker-plain@.service and provide symlink for the old service name pointing to the new one
2. Update spec file to find out if openqa-worker@.service is a symlink and do not change it during updates

Did I miss something?

The PR for the first step is: https://github.com/os-autoinst/openQA/pull/4687

As the PR is merged, next steps should be doing some spec file magic to not overwrite openqa-worker@.service symlink.