QA » openQA Project

code looks like this

430 sub job_next_previous_ajax ($self) {   
431     my $main_job = $self->get_current_job;
432     my $main_jobid = $main_job->id;

and the method get_current_job looks like this:

397 sub get_current_job ($self, $with_assets = 0) {
398     return $self->reply->not_found unless defined $self->param('testid');
399 
400     my $job = $self->schema->resultset("Jobs")
401       ->find($self->param('testid'), {$with_assets ? (prefetch => qw(jobs_assets)) : ()});
402     return $job;
403 }

IMHO a classical problem of one shouldn't use external facing functions internally. So get_current_job does not ensure to always yield a valid job. A suboptimal solution would be to check for the validity of the returned object before trying to access its id.

https://github.com/os-autoinst/openQA/pull/4574 should do that

But likely cleaner would be if we can avoid the explicit value checking with exceptions.

https://github.com/os-autoinst/openQA/pull/4574 merged and deployed on o3. grep 'Can.* call method.*id' /var/log/openqa does not return anything anymore. https://github.com/os-autoinst/openQA/pull/4575 is a followup with a discussion going on.

https://github.com/os-autoinst/openQA/pull/4574 is merged and effective, no more problems observed. Optionally, eventually we can continue with https://github.com/os-autoinst/openQA/pull/4575