QA » openQA Project

I've been thinking a bit about this and the obvious first solution to the problem would be to simply add something like label:\w+ to the already existing exclusion list ((?<![\(\[\"\>])) of prefixes that prevent bugref expansion. But having a list of disallowed prefixes is rather unintuitive for users. So i'd rather like to try a completely different approach first, which is to replace the exclusion list with the requirement that bugrefs need to be placed at the start of the line, or be preceded by whitespace.

kraih wrote:

So i'd rather like to try a completely different approach first, which is to replace the exclusion list with the requirement that bugrefs need to be placed at the start of the line, or be preceded by whitespace.

Do we have examples where that might not be the case? Off head I'd think the common case is simply the bugref on its own and nothing else. So that might effectively make not difference to current use cases.

cdywan wrote:

Do we have examples where that might not be the case? Off head I'd think the common case is simply the bugref on its own and nothing else. So that might effectively make not difference to current use cases.

There was actually a test case with two bugrefs separated by comma (which i've for now included as an alternative to whitespace prefix).

Possible solution. https://github.com/os-autoinst/openQA/pull/4437

For simplicity, i'd prefer not to implement AC2. The bugref regex we use for everything bugref related right now (multiple functions) is fairly complex, but has good test coverage. For AC2 we would need a second version of that regex, which is bound to lower coverage.

Maybe we can revisit AC2 after color highlighting of labels from #104616 has been implemented. That will certainly add more complexity to the situation and bring up new points to discuss.

ok, please extract AC2 into its own ticket, then continue