action #103765
closedQA (public) - coordination #91646: [saga][epic] SUSE Maintenance QA workflows with fully automated testing, approval and release
coordination #89062: [epic] Simplify review for SUSE QAM
coordination #93246: [epic] List all unreviewed failed (or incomplete) jobs on /tests on request size:M
Support for "todo" query parameter on /tests, same as /tests/overview size:M
Description
Motivation¶
As a test reviewer and member of one of many QA squads I want to find unreviewed openQA test failures on /tests to have access to a single page showing all recent failures needing review work.
Also see parent #93246
Acceptance criteria¶
- AC1: A query parameter "todo=1" on /tests can be specified to show only (finished) jobs needing review, same as we do on /tests/overview
Suggestions¶
/tests can already be configured like https://openqa.opensuse.org/tests/?resultfilter=Failed&resultfilter=Incomplete&resultfilter=timeout_exceeded , even over UI elements.
- Try t/ui/01-list.t and see if you can extend it
- Add query parameter to filter only jobs that need review, e.g. "todo=1", same as on /tests/overview . At best use the same logic to prevent duplication
Out of scope¶
- "running" or "scheduled" jobs on /tests as long as they at least show something useful when no manual query parameters are used or no filtering box selection has been made.
- Performance improvements on /tests, as the feature should only be activated on explicit request by users
- The number of jobs that are displayed after all the filters apply. https://openqa.opensuse.org/tests?match=toolkits&resultfilter=Failed is one example showing that there can be enough "review candidates" depending on the specified test suite
- Changing the limit of jobs (e.g. more than 500)
- Filtering the job for other parameters like job group, scenario name, result, state, etc.
Updated by mkittler about 3 years ago
- Subject changed from Support for "todo" query parameter on /tests, same as /tests/overview to Support for "todo" query parameter on /tests, same as /tests/overview size:M
- Description updated (diff)
- Status changed from New to Workable
Updated by kraih about 3 years ago
- Assignee set to kraih
Been some time since i've added a ui feature.
Updated by tinita almost 3 years ago
- Status changed from Workable to Feedback
- Assignee changed from kraih to tinita
Sorry @kraih but you never set it to In Progress and the last status change was 24 days ago ;-)
Updated by okurz almost 3 years ago
PR merged. I deployed manually on o3 now. https://openqa.opensuse.org/tests/?todo=1 shows exactly the same jobs as https://openqa.opensuse.org/tests/ so the change does not seem to be effective for the UI route at least.
Updated by tinita almost 3 years ago
@okurz Can you recheck that you deployed it?
Looking at the javascript https://openqa.opensuse.org/asset/eaf8e17a2c/bootstrap.js I don't find the code I added in there, so that can't work.
Also /usr/share/openqa/assets/javascripts/tests.js on o3 does not show the new code.
And https://openqa.opensuse.org/changelog does not show my commit yet.
btw, I tested it on a local instance when I created the PR, and the test list was affected.
Updated by okurz almost 3 years ago
- Status changed from Feedback to Resolved
all looks good now. Guess the package wasn't fully ready yet previously. Good work!
Updated by okurz almost 3 years ago
- Copied to action #104995: Add UI element and help text for "todo" query parameter on /tests, similar as /tests/overview added