action #10262
closedaction #10260: Improve test coverage
Prevent further test coverage drop
0%
Description
user story¶
As openqa backend as well as test developer I get feedback on the coverage change in my PRs not to introduce coverage regressions (to prevent technical debt increase)
acceptance criteria¶
- PRs are checked for coverage as in https://github.com/os-autoinst/openQA/pull/51
- PRs which introduce test coverage drop are rejected
suggestions¶
- check how coverage is currently gathered or was e.g. in https://github.com/os-autoinst/openQA/pull/51
- research why it does not work for current changes anymore
- re-add coverage analysis to local tests
- re-add coverage analysis to travis/coveralls calls
further notes¶
seems like there was a notification on coverage using coveralls some time ago but it seems it got either disabled or somehow broke. It should be re-enabled and extended to other repositories as available.
Updated by okurz over 8 years ago
- Related to action #1789: openqa test coverage added
Updated by okurz over 8 years ago
this might be of help
https://github.com/jshint/jshint/issues/2498
Updated by okurz over 8 years ago
- Status changed from New to In Progress
Updated by okurz about 8 years ago
- Checklist item changed from [ ] os-autoinst, [ ] openQA, [ ] os-autoinst-distri-opensuse/master, [ ] os-autoinst-distri-opensuse/sle12 to [ ] os-autoinst, [x] openQA, [ ] os-autoinst-distri-opensuse/master, [ ] os-autoinst-distri-opensuse/sle12
with gh#540 merged we got openQA covered, other projects still missing
Updated by okurz about 8 years ago
@oholececk could you please check once more the coveralls settings regarding github PR notifications, see here https://coveralls.zendesk.com/hc/en-us/articles/201774895-Notifications
I don't have push access to openQA and therefore probably don't see the coveralls settings. It did properly show the recent coverage drop by you here https://coveralls.io/builds/5186643/source?filename=lib%2FOpenQA%2FWebAPI%2FController%2FFile.pm but it didn't inform github.
Updated by okurz over 7 years ago
- Checklist item changed from [ ] os-autoinst, [x] openQA, [ ] os-autoinst-distri-opensuse/master, [ ] os-autoinst-distri-opensuse/sle12 to [ ] os-autoinst, [x] openQA, [ ] os-autoinst-distri-opensuse/master
Updated by okurz over 7 years ago
- Assignee changed from oholecek to okurz
coveralls reporting is working currently for openQA.
For os-autoinst see https://github.com/os-autoinst/os-autoinst/pull/569
Updated by okurz over 7 years ago
- Checklist item changed from [ ] os-autoinst, [x] openQA, [ ] os-autoinst-distri-opensuse/master to [x] os-autoinst, [x] openQA, [ ] os-autoinst-distri-opensuse/master
Updated by okurz over 7 years ago
would any admin please enable "os-autoinst" in coveralls.io? It works for my fork: https://coveralls.io/github/okurz/os-autoinst
Updated by okurz over 7 years ago
- Checklist item changed from [x] os-autoinst, [x] openQA, [ ] os-autoinst-distri-opensuse/master to [x] os-autoinst, [x] openQA
- Status changed from In Progress to Resolved
we have proper coveralls check for os-autoinst now, too. openQA and os-autoinst track test coverage changes so all good. The tests never had a coverage analysis so this is a totally different issue and must be tracked elsewhere.