action #10226

openqa comments renders URL incorrectly

Added by okurz about 4 years ago. Updated about 4 years ago.

Status:ResolvedStart date:15/01/2016
Priority:NormalDue date:
Assignee:okurz% Done:

100%

Category:Feature requests
Target version:Milestone 1
Difficulty:
Duration:

Description

observation

http(s)-URLs where the next character is something like ')' are incorrectly rendered with the character included. Also explicit '' is incorrectly rendered.

problem

introduced with https://github.com/okurz/openQA/commit/c3fab4de78964494257611ef2e282e384b0280d4
There should be a better regex.

History

#1 Updated by okurz about 4 years ago

  • Subject changed from openqa comments to openqa comments renders URL with subsequent characters incorrectly
  • Assignee set to okurz

#2 Updated by okurz about 4 years ago

  • Assignee deleted (okurz)

#3 Updated by okurz about 4 years ago

  • Subject changed from openqa comments renders URL with subsequent characters incorrectly to openqa comments renders URL incorrectly
  • Description updated (diff)
  • Assignee set to okurz
  • Priority changed from Low to Normal

coolo you have been working on comments. Can you point me to where I could test rendering of the comments? Looks like input of comments can be checked here:
t/ui/15-comments.t
But it seems I can not check the autoreplace of comments there. ideas?

#4 Updated by coolo about 4 years ago

why not? you have the generated HTML there - and this HTML needs to have your rewrites. Javascript is more complex, but there is no javascript involved.

#5 Updated by RBrownSUSE about 4 years ago

  • Target version set to Milestone 1

#6 Updated by okurz about 4 years ago

  • Status changed from New to Resolved
  • % Done changed from 0 to 100

should be fixed with https://github.com/os-autoinst/openQA/pull/512 as soon as rolled out on productive instances

#7 Updated by okurz about 4 years ago

coolo wrote:

why not? you have the generated HTML there - and this HTML needs to have your rewrites. Javascript is more complex, but there is no javascript involved.

Yeah, resolved. My problem was the call method 'text' on the DOM object which (correctly) put together all text parts which looked like the input to me as the href tags in between were not shown. The test in t/ui/15-comments.t now correctly checks for each individual URL both the text representation as well as the 'a href' part. A bit verbose though.

Also available in: Atom PDF