action #101755
closed
coordination #90086: [epic] Refactor container tests
Make sure that all the container tests are using CONTAINER_RUNTIME variable
Added by jlausuch about 3 years ago.
Updated 3 months ago.
Description
Currently, only tests that are scheduled via main_containers.pm
have CONTAINER_RUNTIME
variable.
But those that are using yaml scheduling don't need to have it.
So, some jobs are running docker and podman tests in the same job. In order to combine test modules like docker_3rd_party_images.pm
and podman_3rd_party_images.pm
together (e.g. 3rd_pary_images
), we need to give the test module which runtime we want to use: podman, docker or both.
This way, we will be able to do something like:
foreach my $runtime (split /,/, $CONTAINER_RUNTIME) {
my $engine = $self->containers_factory($runtime);
# test logic here using $engine
}
- Tracker changed from coordination to action
- Status changed from New to Workable
I would like to vote against that. I have already explained the why. To summarize with the new design we can achieve job variable independence. The module will be able to get scheduled wherever and just run without the tampering of the job variables. less maintenance in long run.
ybonatakis wrote:
I would like to vote against that. I have already explained the why. To summarize with the new design we can achieve job variable independence. The module will be able to get scheduled wherever and just run without the tampering of the job variables. less maintenance in long run.
We have currently jobs that use that variable and jobs that don't, it's very difficult to understand when it's needed and when not. I am just trying to unify all the container tests with common things.
- Status changed from Workable to In Progress
- Assignee set to jlausuch
in O3, I added:
- container-host -> CONTAINER_RUNTIME=podman
- container-host-old2microosnext -> CONTAINER_RUNTIME=podman
- container-host2microosnext -> CONTAINER_RUNTIME=podman
- jeos-containers -> CONTAINER_RUNTIME=docker,podman
- Status changed from In Progress to Resolved
Also available in: Atom
PDF