Project

General

Profile

Actions
Copy link

action #101755

closed

coordination #90086: [epic] Refactor container tests

Make sure that all the container tests are using CONTAINER_RUNTIME variable

Added by jlausuch over 2 years ago. Updated over 2 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
jlausuch
Target version:
-
Start date:
2021-10-30
Due date:
% Done:

0%

Estimated time:

Description

Currently, only tests that are scheduled via main_containers.pm have CONTAINER_RUNTIME variable.
But those that are using yaml scheduling don't need to have it.

So, some jobs are running docker and podman tests in the same job. In order to combine test modules like docker_3rd_party_images.pm and podman_3rd_party_images.pm together (e.g. 3rd_pary_images), we need to give the test module which runtime we want to use: podman, docker or both.

This way, we will be able to do something like:

foreach my $runtime (split /,/, $CONTAINER_RUNTIME) {
    my $engine = $self->containers_factory($runtime);
    # test logic here using $engine
}
Actions
Copy link
 #1

Updated by jlausuch over 2 years ago

  • Tracker changed from coordination to action
Actions
Copy link
 #2

Updated by jlausuch over 2 years ago

  • Status changed from New to Workable
Actions
Copy link
 #3

Updated by ybonatakis over 2 years ago

I would like to vote against that. I have already explained the why. To summarize with the new design we can achieve job variable independence. The module will be able to get scheduled wherever and just run without the tampering of the job variables. less maintenance in long run.

Actions
Copy link
 #4

Updated by jlausuch over 2 years ago

ybonatakis wrote:

I would like to vote against that. I have already explained the why. To summarize with the new design we can achieve job variable independence. The module will be able to get scheduled wherever and just run without the tampering of the job variables. less maintenance in long run.

We have currently jobs that use that variable and jobs that don't, it's very difficult to understand when it's needed and when not. I am just trying to unify all the container tests with common things.

Actions
Copy link
 #5

Updated by jlausuch over 2 years ago

  • Status changed from Workable to In Progress
  • Assignee set to jlausuch
Actions
Copy link
 #6

Updated by jlausuch over 2 years ago

Iteration for JeOS, which uses yaml schedule instead of main_containers.pm
https://gitlab.suse.de/qac/qac-openqa-yaml/-/merge_requests/498

Actions
Copy link
 #7

Updated by jlausuch over 2 years ago

in O3, I added:

  • container-host -> CONTAINER_RUNTIME=podman
  • container-host-old2microosnext -> CONTAINER_RUNTIME=podman
  • container-host2microosnext -> CONTAINER_RUNTIME=podman
  • jeos-containers -> CONTAINER_RUNTIME=docker,podman
Actions
Copy link
 #8

Updated by jlausuch over 2 years ago

  • Status changed from In Progress to Resolved

O3 has been reworked , see https://progress.opensuse.org/issues/97958 and related issues.
All container tests now use main_containers.pm and have CONTAINER_RUNTIME variable.

Actions
Copy link

Also available in: Atom PDF