action #101755
closedcoordination #90086: [epic] Refactor container tests
Make sure that all the container tests are using CONTAINER_RUNTIME variable
0%
Description
Currently, only tests that are scheduled via main_containers.pm have CONTAINER_RUNTIME variable.
But those that are using yaml scheduling don't need to have it.
So, some jobs are running docker and podman tests in the same job. In order to combine test modules like docker_3rd_party_images.pm and podman_3rd_party_images.pm together (e.g. 3rd_pary_images), we need to give the test module which runtime we want to use: podman, docker or both.
This way, we will be able to do something like:
foreach my $runtime (split /,/, $CONTAINER_RUNTIME) {
my $engine = $self->containers_factory($runtime);
# test logic here using $engine
}
Updated by jlausuch about 3 years ago
- Tracker changed from coordination to action
Updated by ybonatakis about 3 years ago
I would like to vote against that. I have already explained the why. To summarize with the new design we can achieve job variable independence. The module will be able to get scheduled wherever and just run without the tampering of the job variables. less maintenance in long run.
Updated by jlausuch about 3 years ago
ybonatakis wrote:
I would like to vote against that. I have already explained the why. To summarize with the new design we can achieve job variable independence. The module will be able to get scheduled wherever and just run without the tampering of the job variables. less maintenance in long run.
We have currently jobs that use that variable and jobs that don't, it's very difficult to understand when it's needed and when not. I am just trying to unify all the container tests with common things.
Updated by jlausuch about 3 years ago
- Status changed from Workable to In Progress
- Assignee set to jlausuch
Updated by jlausuch about 3 years ago
Iteration for JeOS, which uses yaml schedule instead of main_containers.pm
https://gitlab.suse.de/qac/qac-openqa-yaml/-/merge_requests/498
Updated by jlausuch about 3 years ago
in O3, I added:
- container-host -> CONTAINER_RUNTIME=podman
- container-host-old2microosnext -> CONTAINER_RUNTIME=podman
- container-host2microosnext -> CONTAINER_RUNTIME=podman
- jeos-containers -> CONTAINER_RUNTIME=docker,podman
Updated by jlausuch about 3 years ago
- Status changed from In Progress to Resolved
O3 has been reworked , see https://progress.opensuse.org/issues/97958 and related issues.
All container tests now use main_containers.pm and have CONTAINER_RUNTIME variable.