QA » openQA Project » openQA Tests » Containers

Blocked by: https://progress.opensuse.org/issues/101442

Engine class is not the proper place for it.
As i have mentioned here the design should not mix interrelated ideas. The Engine should deal with container engine tools. The installation is different topic.

Now I honestly don't know what to do.

As discussed during a call, this might not be the best solution.
Alternative proposals:

• Leave install_podman_when_needed where it is, so others can use it without creating the engine object, and call to this function in the Factory after creating engine.
• Leave everything as it is, the test modules are responsible for installing the packages (current situation).
• Add host_configuration.pm to all the container tests and call the installation of packages ONLY there (remove it from the tests modules).

jlausuch wrote:

As discussed during a call, this might not be the best solution.
Alternative proposals:

• Leave install_podman_when_needed where it is, so others can use it without creating the engine object, and call to this function in the Factory after creating engine.
• Leave everything as it is, the test modules are responsible for installing the packages (current situation).
• Add host_configuration.pm to all the container tests and call the installation of packages ONLY there (remove it from the tests modules).

I vote for the first approach of calling install_podman_when_needed after creating the engine object.

pdostal wrote:

jlausuch wrote:

As discussed during a call, this might not be the best solution.
Alternative proposals:

• Leave install_podman_when_needed where it is, so others can use it without creating the engine object, and call to this function in the Factory after creating engine.
• Leave everything as it is, the test modules are responsible for installing the packages (current situation).
• Add host_configuration.pm to all the container tests and call the installation of packages ONLY there (remove it from the tests modules).

I vote for the first approach of calling install_podman_when_needed after creating the engine object.

Me too. I would go even further and create a init() function for engine Class where we do those calls, and in factory we just do $engine->init(), same as for public cloud.

jlausuch wrote:

As discussed during a call, this might not be the best solution.
Alternative proposals:

Some ideas:

• Leave install_podman_when_needed where it is, so others can use it without creating the engine object, and call to this function in the Factory after creating engine.

my $engine = $self->containers_factory('podman');
$engine->init();

i think it makes sense to have an init()(or install() if you want) in the containers::basetest. in this case, containers_factory doesnt need to take care of anything else or be modified, and serves one purpose as factory. But as containers::basetest, we can include and provide that logic here.

• Leave everything as it is, the test modules are responsible for installing the packages (current situation).
• Add host_configuration.pm to all the container tests and call the installation of packages ONLY there (remove it from the tests modules).

it is an option but i kinda afraid this as it will create module dependencies. it could be used as plan B. if host_configuration.pm is not suitable, we might make another module (container_install.pm)

i have also other things in mind but i think it is a bit more complicated so not to consider at the moment

Ok, do we agree for now to leave the install functions where they are and create a function init() in the engines to call those functions?

jlausuch wrote:

Ok, do we agree for now to leave the install functions where they are and create a function init() in the engines to call those functions?

Yes.

created this ticket for it