Actions
action #101379
closedReduce amount of unhelpful log messages at debug level
Description
Observation¶
Even though we keep a lot of logs on OSD, most of it is unhelpful for day to day debugging tasks. Especially the token and API key messages
take up a lot of disk space and provide little value. Mojolicious recently introduced a new log level below debug
called trace
,
that could be used for these and similar log messages.
[2021-10-21T10:00:12.976949+02:00] [debug] [DhPF1FwhQ81e] 200 OK (0s, ??/s)
[2021-10-21T10:00:12.977305+02:00] [debug] [MknhbAKzf44C] 200 OK (0s, ??/s)
[2021-10-21T10:00:12.977339+02:00] [debug] Received JobToken: A1234567890
[2021-10-21T10:00:12.977642+02:00] [debug] API key from client: *B1234567890*
[2021-10-21T10:00:12.978024+02:00] [debug] API key from client: *C1234567890*
[2021-10-21T10:00:12.978031+02:00] [debug] API key from client: *D1234567890*
Acceptance criteria¶
- AC1: Review OSD/O3 logs to identify unhelpful log messages
- AC2: Add necessary APIs and tests to support
trace
log level - AC3: Move unhelpful log messages to
trace
level (or remove them completely if they serve no real purpose)
Suggestion¶
- Ignore
[DhPF1FwhQ81e] 200 OK (0s, ??/s)
log messages, since they are a Mojolicious bug that will be gone with the next update
Updated by kraih almost 3 years ago
- Related to action #96551: Persistent records of systemd journal size:S added
Updated by kraih almost 3 years ago
- Status changed from New to In Progress
Updated by livdywan almost 3 years ago
kraih wrote:
Since Mergify doesn't seem to care about open comments, I'm mentioning it here: This PR bumps the minimum Mojo version to 9.20
Updated by tinita almost 3 years ago
- Target version changed from future to Ready
Actions