action #132776
Updated by JERiveraMoya 10 months ago
#### Motivation
Modify this test module so it will very readable and the user can distinguish well what is the setup without going in depth in the code. [setup_sle.pm](https://github.com/os-autoinst/os-autoinst-distri-opensuse/blob/master/tests/migration/setup_sle.pm)
sle 15 that is our target for now, due to is where we can use libyui-rest-api and have all the improvements together, refactor + libyui-rest-api. Taking a look to `sub setup_sle`:
- Search why we need this (git history?) and write a comment with the answer:
`assert_script_run "chmod 444 /usr/sbin/packagekitd";`
- This is not needed here, but in the previous module that does the patching: wait_quit_zypper;
- why to do this again? `ensure_serialdev_permissions` the console at this point is working fine in openQA ..
- why we run this for the-system-to-be-migrated `enter_cmd "echo 'export Y2DEBUG=1' >> /etc/bash.bashrc.local";` I mean we can increase debug log in the installer for migration and in the system migrated you can open modules with that setting, but at this point I don't find the meaning...
- we don't need to take into account set_zypp_single_rpmtrans.
- We need to remove this logic `set_var('HDD_SCC_REGISTERED', 1) if get_var('KEEP_REGISTERED');` is unclear why we need this hack, perhaps we can resolve this by schedule, please describe goal of this with example.
#### Acceptance criteria
**AC1**: Apply the improvements described above answering all those questions so the test module is very readable
#### Additional information
Refactored test suite are currently in [this job group](https://openqa.suse.de/tests/overview?distri=sle&version=15-SP5&build=102.1&groupid=319) with names ending on `*_split_patch_sle`.